fix: Modify Experiment collision naming from dot-notation to dash #1646
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: khhirani <kareena.hirani@gmail.com>
harikrongali
approved these changes
Nov 11, 2021
|
@khhirani can you rebase to latest and rerun e2e & unit tests |
…to exp-collision-naming
|
SonarCloud Quality Gate failed.
|
Codecov Report
@@ Coverage Diff @@
## master #1646 +/- ##
=======================================
Coverage 81.94% 81.94%
=======================================
Files 115 115
Lines 15871 15871
=======================================
Hits 13006 13006
Misses 2196 2196
Partials 669 669
Continue to review full report at Codecov.
|
|
@khhirani can you check e2e tests? |
alexmt
approved these changes
Nov 18, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #1631
Signed-off-by: khhirani kareena.hirani@gmail.com