fix: Modify Experiment collision naming from dot-notation to dash (#1646

) Signed-off-by: khhirani <kareena.hirani@gmail.com>
argoproj · Nov 29, 2021 · 9432caf · 9432caf
1 parent ec00dd6
commit 9432caf
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/rollout/experiment.go b/rollout/experiment.go
@@ -230,7 +230,7 @@ func (c *rolloutContext) createExperimentWithCollisionHandling(newEx *v1alpha1.E
 			// we likely reconciled the rollout with a stale cache (quite common).
 			return existingEx, nil
 		}
-		newEx.Name = fmt.Sprintf("%s.%d", baseName, collisionCount)
+		newEx.Name = fmt.Sprintf("%s-%d", baseName, collisionCount)
 		collisionCount++
 	}
 }

diff --git a/rollout/experiment_test.go b/rollout/experiment_test.go
@@ -165,7 +165,7 @@ func TestCreateExperimentWithCollision(t *testing.T) {
 
 	f.run(getKey(r2, t))
 	createdEx := f.getCreatedExperiment(createExIndex)
-	assert.Equal(t, ex.Name+".1", createdEx.Name)
+	assert.Equal(t, ex.Name+"-1", createdEx.Name)
 	patch := f.getPatchedRollout(patchIndex)
 	expectedPatch := `{
 		"status": {