Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ui): UI crashes on rollout view due to undefined status #1287

Merged
merged 1 commit into from
Jun 17, 2021

Conversation

rbreeze
Copy link
Member

@rbreeze rbreeze commented Jun 16, 2021

Signed-off-by: Remington Breeze remington@breeze.software

Fixes #1280

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this is a chore.
  • The title of the PR is (a) conventional, (b) states what changed, and (c) suffixes the related issues number. E.g. "fix(controller): Updates such and such. Fixes #1234".
  • I've signed my commits with DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My builds are green. Try syncing with master if they are not.
  • My organization is added to USERS.md.

Signed-off-by: Remington Breeze <remington@breeze.software>
@rbreeze rbreeze requested a review from jessesuen June 16, 2021 20:41
@sonarcloud
Copy link

sonarcloud bot commented Jun 16, 2021

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 5 Code Smells

No Coverage information No Coverage information
2.6% 2.6% Duplication

@codecov
Copy link

codecov bot commented Jun 16, 2021

Codecov Report

Merging #1287 (1e2a794) into master (07354b3) will increase coverage by 0.18%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1287      +/-   ##
==========================================
+ Coverage   81.21%   81.39%   +0.18%     
==========================================
  Files         105      106       +1     
  Lines        9495     9604     +109     
==========================================
+ Hits         7711     7817     +106     
+ Misses       1269     1259      -10     
- Partials      515      528      +13     
Impacted Files Coverage Δ
controller/metrics/analysis.go 82.00% <0.00%> (-18.00%) ⬇️
controller/metrics/experiments.go 83.33% <0.00%> (-16.67%) ⬇️
utils/log/log.go 94.00% <0.00%> (-6.00%) ⬇️
pkg/kubectl-argo-rollouts/cmd/promote/promote.go 93.90% <0.00%> (-2.05%) ⬇️
pkg/kubectl-argo-rollouts/cmd/lint/lint.go 68.33% <0.00%> (-1.44%) ⬇️
utils/defaults/defaults.go 85.71% <0.00%> (-1.33%) ⬇️
rollout/trafficrouting/alb/alb.go 81.25% <0.00%> (-0.90%) ⬇️
rollout/service.go 78.66% <0.00%> (-0.29%) ⬇️
rollout/trafficrouting/istio/istio.go 78.66% <0.00%> (-0.27%) ⬇️
pkg/kubectl-argo-rollouts/cmd/status/status.go 93.22% <0.00%> (-0.23%) ⬇️
... and 30 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 07354b3...1e2a794. Read the comment docs.

@jessesuen jessesuen merged commit e2f87a4 into argoproj:master Jun 17, 2021
perenesenko pushed a commit to perenesenko/argo-rollouts that referenced this pull request Jun 22, 2021
…#1287)

Signed-off-by: Remington Breeze <remington@breeze.software>
Signed-off-by: Andrii Perenesenko <andrii.perenesenko@gmail.com>
mbhatip pushed a commit to mbhatip/argo-rollouts that referenced this pull request Jun 22, 2021
…#1287)

Signed-off-by: Remington Breeze <remington@breeze.software>
mbhatip pushed a commit to mbhatip/argo-rollouts that referenced this pull request Jun 22, 2021
…#1287)

Signed-off-by: Remington Breeze <remington@breeze.software>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Argo Rollouts Dashboard error
2 participants