Skip to content

Commit

Permalink
fix: unhandled error patchVirtualService (#1168)
Browse files Browse the repository at this point in the history
Signed-off-by: Andrii Perenesenko <andrii.perenesenko@gmail.com>
  • Loading branch information
perenesenko authored May 12, 2021
1 parent ce83589 commit 07354b3
Showing 1 changed file with 4 additions and 1 deletion.
5 changes: 4 additions & 1 deletion rollout/trafficrouting/istio/istio.go
Original file line number Diff line number Diff line change
Expand Up @@ -153,7 +153,10 @@ func (r *Reconciler) reconcileVirtualService(obj *unstructured.Unstructured, des
}

patches := r.generateVirtualServicePatches(httpRoutes, int64(desiredWeight))
patches.patchVirtualService(httpRoutesI)
err = patches.patchVirtualService(httpRoutesI)
if err != nil {
return nil, false, err
}

err = unstructured.SetNestedSlice(newObj.Object, httpRoutesI, "spec", "http")
return newObj, len(patches) > 0, err
Expand Down

0 comments on commit 07354b3

Please sign in to comment.