Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix analysis template arguments validate #1038

Merged
merged 1 commit into from
Mar 19, 2021

Conversation

zcc35357949
Copy link
Contributor

Signed-off-by: zhouchencheng zhouchencheng@bilibili.com

fix #1032

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this is a chore.
  • The title of the PR is (a) conventional, (b) states what changed, and (c) suffixes the related issues number. E.g. "fix(controller): Updates such and such. Fixes #1234".
  • I've signed my commits with DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My builds are green. Try syncing with master if they are not.
  • My organization is added to USERS.md.

@codecov
Copy link

codecov bot commented Mar 18, 2021

Codecov Report

Merging #1038 (4918862) into master (5f1c185) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1038   +/-   ##
=======================================
  Coverage   80.90%   80.91%           
=======================================
  Files         102      102           
  Lines        9093     9097    +4     
=======================================
+ Hits         7357     7361    +4     
  Misses       1242     1242           
  Partials      494      494           
Impacted Files Coverage Δ
.../apis/rollouts/validation/validation_references.go 74.28% <100.00%> (+1.01%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5f1c185...4918862. Read the comment docs.

@jessesuen
Copy link
Member

Thank you for the fix! This seems like an easy issue to add a unit test against. Do you mind adding one against ValidateAnalysisTemplateWithType that can verify the fix?

@zcc35357949
Copy link
Contributor Author

Thank you for the fix! This seems like an easy issue to add a unit test against. Do you mind adding one against ValidateAnalysisTemplateWithType that can verify the fix?

Done!

Signed-off-by: zhouchencheng <zhouchencheng@bilibili.com>
@sonarcloud
Copy link

sonarcloud bot commented Mar 19, 2021

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@jessesuen jessesuen merged commit d23a240 into argoproj:master Mar 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tip of master Rollout complains about missing AnalysisTemplate arg
2 participants