fix analysis template arguments validate

Signed-off-by: zhouchencheng <zhouchencheng@bilibili.com>
argoproj · Mar 19, 2021 · 53c582c · 53c582c
1 parent 8111b1e
commit 53c582c
Showing 1 changed file with 11 additions and 0 deletions.
diff --git a/pkg/apis/rollouts/validation/validation_references_test.go b/pkg/apis/rollouts/validation/validation_references_test.go
@@ -173,6 +173,17 @@ func TestValidateAnalysisTemplateWithType(t *testing.T) {
 		assert.Equal(t, expectedError.Error(), allErrs[0].Error())
 	})
 
+	t.Run("validate inline analysisTemplate argument - success", func(t *testing.T) {
+		template := getAnalysisTemplateWithType()
+		template.AnalysisTemplate.Spec.Args = []v1alpha1.Argument{
+			{
+				Name: "service-name",
+			},
+		}
+		allErrs := ValidateAnalysisTemplateWithType(template)
+		assert.Empty(t, allErrs)
+	})
+
 	// verify background analysis does not care about a metric that runs indefinitely
 	t.Run("validate background analysisTemplate - success", func(t *testing.T) {
 		count := intstr.FromInt(0)