-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(argo-workflows): Add support for extra containers in server & controller deployment #841
Merged
oliverbaehler
merged 5 commits into
argoproj:master
from
mikebryant:add-support-for-extra-containers
Aug 11, 2021
Merged
feat(argo-workflows): Add support for extra containers in server & controller deployment #841
oliverbaehler
merged 5 commits into
argoproj:master
from
mikebryant:add-support-for-extra-containers
Aug 11, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
f89e2a0
to
cff6d3d
Compare
Signed-off-by: Mike Bryant <mikebryant@bulb.co.uk>
cff6d3d
to
2020aaf
Compare
Some basic testing:
|
oliverbaehler
suggested changes
Aug 10, 2021
charts/argo-workflows/templates/controller/workflow-controller-deployment.yaml
Outdated
Show resolved
Hide resolved
…-deployment.yaml Co-authored-by: Oliver Bähler <oliverbaehler@hotmail.com> Signed-off-by: Mike Bryant <mike@mikebryant.me.uk>
Co-authored-by: Oliver Bähler <oliverbaehler@hotmail.com> Signed-off-by: Mike Bryant <mike@mikebryant.me.uk>
4b47052
to
f089fdc
Compare
Thanks for the review, have applied the requested changes :) |
oliverbaehler
approved these changes
Aug 11, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, @mikebryant Thanks for your contribution.
terrych0u
pushed a commit
to terrych0u/argo-helm
that referenced
this pull request
Sep 7, 2021
…ntroller deployment (argoproj#841) * feat: Add support for extra containers in server & controller deployment Signed-off-by: Mike Bryant <mikebryant@bulb.co.uk> * Update charts/argo-workflows/templates/controller/workflow-controller-deployment.yaml Co-authored-by: Oliver Bähler <oliverbaehler@hotmail.com> Signed-off-by: Mike Bryant <mike@mikebryant.me.uk> * Update charts/argo-workflows/templates/server/server-deployment.yaml Co-authored-by: Oliver Bähler <oliverbaehler@hotmail.com> Signed-off-by: Mike Bryant <mike@mikebryant.me.uk> Co-authored-by: Oliver Bähler <oliverbaehler@hotmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
My use-case for this is using persistence with a GCP CloudSQL database, using the sidecar pattern for the cloud-sql-proxy
Note on DCO:
If the DCO action in the integration test fails, one or more of your commits are not signed off. Please click on the Details link next to the DCO action for instructions on how to resolve this.
Checklist:
Changes are automatically published when merged to
master
. They are not published on branches.