Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(argo-workflows): Add support for extra containers in server & controller deployment #841

Merged

Conversation

mikebryant
Copy link
Contributor

@mikebryant mikebryant commented Jul 20, 2021

My use-case for this is using persistence with a GCP CloudSQL database, using the sidecar pattern for the cloud-sql-proxy

Note on DCO:

If the DCO action in the integration test fails, one or more of your commits are not signed off. Please click on the Details link next to the DCO action for instructions on how to resolve this.

Checklist:

  • I have bumped the chart version according to versioning
  • I have updated the chart changelog with all the changes that come with this pull request according to changelog.
  • Any new values are backwards compatible and/or have sensible default.
  • I have signed off all my commits as required by DCO.
  • My build is green (troubleshooting builds).

Changes are automatically published when merged to master. They are not published on branches.

Signed-off-by: Mike Bryant <mikebryant@bulb.co.uk>
@mikebryant mikebryant force-pushed the add-support-for-extra-containers branch from cff6d3d to 2020aaf Compare July 20, 2021 13:41
@mikebryant mikebryant marked this pull request as draft July 20, 2021 13:44
@mikebryant mikebryant marked this pull request as ready for review July 20, 2021 13:46
@mikebryant
Copy link
Contributor Author

Some basic testing:

mikebryant@BULB-MB-0246 argo-workflows % cat env.yaml
server:
  extraContainers:
    - name: blah
      image: blah
mikebryant@BULB-MB-0246 argo-workflows % helm template . --values env.yaml | tail
          - name: tmp
            mountPath: /tmp

        - image: blah
          name: blah
      volumes:
      - name: tmp
        emptyDir: {}
      nodeSelector:
        kubernetes.io/os: linux

@mikebryant mikebryant changed the title feat: Add support for extra containers in server & controller deployment feat(argo-workflows): Add support for extra containers in server & controller deployment Jul 20, 2021
mikebryant and others added 2 commits August 10, 2021 23:24
…-deployment.yaml

Co-authored-by: Oliver Bähler <oliverbaehler@hotmail.com>
Signed-off-by: Mike Bryant <mike@mikebryant.me.uk>
Co-authored-by: Oliver Bähler <oliverbaehler@hotmail.com>
Signed-off-by: Mike Bryant <mike@mikebryant.me.uk>
@mikebryant mikebryant force-pushed the add-support-for-extra-containers branch from 4b47052 to f089fdc Compare August 10, 2021 22:24
@mikebryant
Copy link
Contributor Author

Thanks for the review, have applied the requested changes :)

Copy link
Contributor

@oliverbaehler oliverbaehler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, @mikebryant Thanks for your contribution.

@oliverbaehler oliverbaehler merged commit 07c1cf0 into argoproj:master Aug 11, 2021
terrych0u pushed a commit to terrych0u/argo-helm that referenced this pull request Sep 7, 2021
…ntroller deployment (argoproj#841)

* feat: Add support for extra containers in server & controller deployment

Signed-off-by: Mike Bryant <mikebryant@bulb.co.uk>

* Update charts/argo-workflows/templates/controller/workflow-controller-deployment.yaml

Co-authored-by: Oliver Bähler <oliverbaehler@hotmail.com>
Signed-off-by: Mike Bryant <mike@mikebryant.me.uk>

* Update charts/argo-workflows/templates/server/server-deployment.yaml

Co-authored-by: Oliver Bähler <oliverbaehler@hotmail.com>
Signed-off-by: Mike Bryant <mike@mikebryant.me.uk>

Co-authored-by: Oliver Bähler <oliverbaehler@hotmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants