Skip to content

Commit

Permalink
feat(argo-workflows): Add support for extra containers in server & co…
Browse files Browse the repository at this point in the history
…ntroller deployment (#841)

* feat: Add support for extra containers in server & controller deployment

Signed-off-by: Mike Bryant <mikebryant@bulb.co.uk>

* Update charts/argo-workflows/templates/controller/workflow-controller-deployment.yaml

Co-authored-by: Oliver Bähler <oliverbaehler@hotmail.com>
Signed-off-by: Mike Bryant <mike@mikebryant.me.uk>

* Update charts/argo-workflows/templates/server/server-deployment.yaml

Co-authored-by: Oliver Bähler <oliverbaehler@hotmail.com>
Signed-off-by: Mike Bryant <mike@mikebryant.me.uk>

Co-authored-by: Oliver Bähler <oliverbaehler@hotmail.com>
  • Loading branch information
mikebryant and oliverbaehler authored Aug 11, 2021
1 parent 4e4c28a commit 07c1cf0
Show file tree
Hide file tree
Showing 4 changed files with 12 additions and 2 deletions.
4 changes: 2 additions & 2 deletions charts/argo-workflows/Chart.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ apiVersion: v2
name: argo-workflows
description: A Helm chart for Argo Workflows
type: application
version: 0.2.13
version: 0.3.0
appVersion: "v3.0.7"
icon: https://raw.githubusercontent.com/argoproj/argo-workflows/master/docs/assets/argo.png
home: https://github.com/argoproj/argo-helm
Expand All @@ -15,4 +15,4 @@ maintainers:
- name: benjaminws
annotations:
artifacthub.io/changes: |
- "[Added]: pathType variable now available for ingress template"
- "[Added]: Support for extraContainers in controller/server"
Original file line number Diff line number Diff line change
Expand Up @@ -79,6 +79,9 @@ spec:
containerPort: {{ .Values.controller.metricsConfig.port }}
- containerPort: 6060
livenessProbe: {{ .Values.controller.livenessProbe | toYaml | nindent 12 }}
{{- with .Values.controller.extraContainers }}
{{- toYaml . | nindent 8 }}
{{- end }}
{{- with .Values.images.pullSecrets }}
imagePullSecrets:
{{- toYaml . | nindent 8 }}
Expand Down
3 changes: 3 additions & 0 deletions charts/argo-workflows/templates/server/server-deployment.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -80,6 +80,9 @@ spec:
{{- with .Values.server.volumeMounts }}
{{- toYaml . | nindent 10}}
{{- end }}
{{- with .Values.server.extraContainers }}
{{- toYaml . | nindent 8 }}
{{- end }}
{{- with .Values.images.pullSecrets }}
imagePullSecrets:
{{- toYaml . | nindent 8 }}
Expand Down
4 changes: 4 additions & 0 deletions charts/argo-workflows/values.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -170,6 +170,8 @@ controller:
clusterWorkflowTemplates:
# Create a ClusterRole and CRB for the controller to access ClusterWorkflowTemplates.
enabled: true
# Extra containers to be added to the controller deployment
extraContainers: []

# executor controls how the init and wait container should be customized
executor:
Expand Down Expand Up @@ -337,6 +339,8 @@ server:
## decisions.
# scopes:
# - groups
# Extra containers to be added to the server deployment
extraContainers: []

# Influences the creation of the ConfigMap for the workflow-controller itself.
useDefaultArtifactRepo: false
Expand Down

0 comments on commit 07c1cf0

Please sign in to comment.