docs(argo-workflows): Add missing value on values.yaml #782
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: yu-croco <yuki.kita22@gmail.com>
yu-croco
requested review from
oliverbaehler,
stefansedich,
vladlosev and
yann-soubeyrand
as code owners
yu-croco
commented
Jun 3, 2021
mkilchhofer
reviewed
Jun 3, 2021
mkilchhofer
changed the title
Signed-off-by: yu-croco <yuki.kita22@gmail.com>
mkilchhofer
reviewed
Jun 3, 2021
Signed-off-by: Marco Kilchhofer <mkilchhofer@users.noreply.github.com>
mkilchhofer
reviewed
Jun 3, 2021
Signed-off-by: Marco Kilchhofer <mkilchhofer@users.noreply.github.com>
mkilchhofer
approved these changes
Jun 3, 2021
terrych0u
pushed a commit
to terrych0u/argo-helm
that referenced
this pull request
Sep 7, 2021
* chore(argo-workflows): Add missing value Signed-off-by: yu-croco <yuki.kita22@gmail.com> * reflect review: make it shorter and clearer. Signed-off-by: yu-croco <yuki.kita22@gmail.com> * Apply suggestions from code review Signed-off-by: Marco Kilchhofer <mkilchhofer@users.noreply.github.com> * Apply suggestions from code review Signed-off-by: Marco Kilchhofer <mkilchhofer@users.noreply.github.com> Co-authored-by: Marco Kilchhofer <mkilchhofer@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: yu-croco yuki.kita22@gmail.com
In this PR #769 ,
fullnameOverridewas added but it was not defined onvalues.yaml, so I added it. 🙋Note on DCO:
If the DCO action in the integration test fails, one or more of your commits are not signed off. Please click on the Details link next to the DCO action for instructions on how to resolve this.
Checklist:
Chart.yamlfollowing Semantic Versioning.Changes are automatically published when merged to
master. They are not published on branches.