Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(argo-workflows): Add support for fullnameOverride #769

Merged
merged 2 commits into from
May 31, 2021
Merged

feat(argo-workflows): Add support for fullnameOverride #769

merged 2 commits into from
May 31, 2021

Conversation

mkilchhofer
Copy link
Member

@mkilchhofer mkilchhofer commented May 29, 2021

This relates to #754

/cc: @chgl and @weisjohn

Note on DCO:

If the DCO action in the integration test fails, one or more of your commits are not signed off. Please click on the Details link next to the DCO action for instructions on how to resolve this.

Checklist:

  • I have updated the chart version in Chart.yaml following Semantic Versioning.
  • Any new values are backwards compatible and/or have sensible default.
  • I have followed the testing instructions in the contributing guide.
  • I have signed off all my commits as required by DCO.
  • My build is green (troubleshooting builds).

Changes are automatically published when merged to master. They are not published on branches.

Signed-off-by: Marco Kilchhofer <mkilchhofer@users.noreply.github.com>
Copy link
Contributor

@oliverbaehler oliverbaehler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mkilchhofer mkilchhofer merged commit b3b6a38 into argoproj:master May 31, 2021
@mkilchhofer mkilchhofer deleted the feature/argo-workflows_fullnameOverride branch May 31, 2021 16:18
terrych0u pushed a commit to terrych0u/argo-helm that referenced this pull request Sep 7, 2021
Signed-off-by: Marco Kilchhofer <mkilchhofer@users.noreply.github.com>

Co-authored-by: Oliver Bähler <oliverbaehler@hotmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants