-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(argocd-image-updater): Update dependency argoproj-labs/argocd-image-updater to v0.15.0 #2988
chore(argocd-image-updater): Update dependency argoproj-labs/argocd-image-updater to v0.15.0 #2988
Conversation
v0.15.0 adds new clusterrole and binding which should be included |
📝 The original info is argoproj-labs/argocd-image-updater#847 . |
We need to add ClusterRole and ClusterRoleBinding in rbac.yaml like below and I have two questions ... 🤔
@mkilchhofer @imranismail WDYT? 🫠 {{- if .Values.rbac.enabled }}
---
apiVersion: rbac.authorization.k8s.io/v1
kind: ClusterRole
metadata:
labels:
{{- include "argocd-image-updater.labels" . | nindent 4 }}
name: {{ include "argocd-image-updater.fullname" . }}
namespace: {{ include "argocd-image-updater.namespace" . | quote }}
rules:
- apiGroups:
- ""
resources:
- events
verbs:
- create
- apiGroups:
- argoproj.io
resources:
- applications
verbs:
- get
- list
- update
- patch
---
apiVersion: rbac.authorization.k8s.io/v1
kind: ClusterRoleBinding
metadata:
labels:
{{- include "argocd-image-updater.labels" . | nindent 4 }}
name: {{ include "argocd-image-updater.fullname" . }}
namespace: {{ include "argocd-image-updater.namespace" . | quote }}
roleRef:
apiGroup: rbac.authorization.k8s.io
kind: ClusterRole
name: {{ include "argocd-image-updater.fullname" . }}
subjects:
- kind: ServiceAccount
name: {{ include "argocd-image-updater.serviceAccountName" . }}
namespace: "argocd" # How can we define as values.yaml?
{{- end }}
|
0016d44
to
9cf5e56
Compare
I think we can use the clusterrole directly as-is from upstream. We need to grant access for creating Events to the ServiceAccount of the AIU, not reuse the ServiceAccount of Argo CD. We could use an and with a pattern used in argo-cd chart: argo-helm/charts/argo-cd/values.yaml Lines 23 to 24 in 85121e8
What about like this? :
|
Hi @mkilchhofer , thank you for your reply. That's a good idea. |
…mage-updater to v0.15.0 Signed-off-by: argoproj-renovate[bot] <161757507+argoproj-renovate[bot]@users.noreply.github.com>
9cf5e56
to
e9d04b3
Compare
The version update will be handled in #2992 |
Renovate Ignore NotificationBecause you closed this PR without merging, Renovate will ignore this update ( If you accidentally closed this PR, or if you changed your mind: rename this PR to get a fresh replacement PR. |
This PR contains the following updates:
v0.14.0
->v0.15.0
Release Notes
argoproj-labs/argocd-image-updater (argoproj-labs/argocd-image-updater)
v0.15.0
Compare Source
What's Changed
New Contributors
Full Changelog: argoproj-labs/argocd-image-updater@v0.14.0...v0.15.0
Configuration
📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR is behind base branch, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.
This PR has been generated by Renovate Bot.