Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(argocd-image-updater): Update dependency argoproj-labs/argocd-image-updater to v0.15.0 #2988

Conversation

argoproj-renovate[bot]
Copy link
Contributor

@argoproj-renovate argoproj-renovate bot commented Oct 22, 2024

This PR contains the following updates:

Package Update Change
argoproj-labs/argocd-image-updater minor v0.14.0 -> v0.15.0

Release Notes

argoproj-labs/argocd-image-updater (argoproj-labs/argocd-image-updater)

v0.15.0

Compare Source

What's Changed

New Contributors

Full Changelog: argoproj-labs/argocd-image-updater@v0.14.0...v0.15.0


Configuration

📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Whenever PR is behind base branch, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box

This PR has been generated by Renovate Bot.

@kyleli666
Copy link

@yu-croco
Copy link
Collaborator

📝 The original info is argoproj-labs/argocd-image-updater#847 .

@yu-croco
Copy link
Collaborator

We need to add ClusterRole and ClusterRoleBinding in rbac.yaml like below and I have two questions ... 🤔

  • Can if condition be same as Role/Rolebinding, if .Values.rbac.enabled ?
  • How do we define argocd namespace in ClusterRoleBinding in value.yaml ?
    • .Values.rbac.argocdNamespace ??? There is the value config.argocd.xxx but it's for flags.

@mkilchhofer @imranismail WDYT? 🫠

{{- if .Values.rbac.enabled }}
---
apiVersion: rbac.authorization.k8s.io/v1
kind: ClusterRole
metadata:
  labels:
    {{- include "argocd-image-updater.labels" . | nindent 4 }}
  name: {{ include "argocd-image-updater.fullname" . }}
  namespace: {{ include "argocd-image-updater.namespace" . | quote }}
rules:
  - apiGroups:
    - ""
    resources:
      - events
    verbs:
      - create
  - apiGroups:
      - argoproj.io
    resources:
      - applications
    verbs:
      - get
      - list
      - update
      - patch
---
apiVersion: rbac.authorization.k8s.io/v1
kind: ClusterRoleBinding
metadata:
  labels:
    {{- include "argocd-image-updater.labels" . | nindent 4 }}
  name: {{ include "argocd-image-updater.fullname" . }}
  namespace: {{ include "argocd-image-updater.namespace" . | quote }}
roleRef:
  apiGroup: rbac.authorization.k8s.io
  kind: ClusterRole
  name: {{ include "argocd-image-updater.fullname" . }}
subjects:
  - kind: ServiceAccount
    name: {{ include "argocd-image-updater.serviceAccountName" . }}
    namespace: "argocd" # How can we define as values.yaml?
{{- end }}

@argoproj-renovate argoproj-renovate bot force-pushed the renovate/argoproj-labs-argocd-image-updater-0.x branch from 0016d44 to 9cf5e56 Compare October 23, 2024 18:21
@mkilchhofer
Copy link
Member

How do we define argocd namespace in ClusterRoleBinding in value.yaml ?

  • .Values.rbac.argocdNamespace ??? There is the value config.argocd.xxx but it's for flags.

I think we can use the clusterrole directly as-is from upstream. We need to grant access for creating Events to the ServiceAccount of the AIU, not reuse the ServiceAccount of Argo CD.

See: https://github.com/argoproj-labs/argocd-image-updater/pull/848/files#diff-085adbc8bea5279ae0da31de54e660d34708509979e708a566d8e5f5339822d8R84

We could use an and with a pattern used in argo-cd chart:

## Used when you manage applications in the same cluster where Argo CD runs
createClusterRoles: true

What about like this? :

{{- if and .Values.rbac.enabled .Values.createClusterRoles }}

@yu-croco
Copy link
Collaborator

Hi @mkilchhofer , thank you for your reply. That's a good idea.
I made a PR #2992 . 🙋

…mage-updater to v0.15.0

Signed-off-by: argoproj-renovate[bot] <161757507+argoproj-renovate[bot]@users.noreply.github.com>
@argoproj-renovate argoproj-renovate bot force-pushed the renovate/argoproj-labs-argocd-image-updater-0.x branch from 9cf5e56 to e9d04b3 Compare October 26, 2024 10:18
@yu-croco
Copy link
Collaborator

The version update will be handled in #2992

@yu-croco yu-croco closed this Oct 26, 2024
@argoproj-renovate
Copy link
Contributor Author

Renovate Ignore Notification

Because you closed this PR without merging, Renovate will ignore this update (v0.15.0). You will get a PR once a newer version is released. To ignore this dependency forever, add it to the ignoreDeps array of your Renovate config.

If you accidentally closed this PR, or if you changed your mind: rename this PR to get a fresh replacement PR.

@argoproj-renovate argoproj-renovate bot deleted the renovate/argoproj-labs-argocd-image-updater-0.x branch October 26, 2024 11:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants