Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CreateApplicationEvent failure when App is in other namespace #847

Closed
jortkoopmans opened this issue Aug 30, 2024 · 2 comments
Closed

CreateApplicationEvent failure when App is in other namespace #847

jortkoopmans opened this issue Aug 30, 2024 · 2 comments
Labels
bug Something isn't working

Comments

@jortkoopmans
Copy link
Contributor

Describe the bug
When running (latest/master branch) updater, with Applications in other namespaces, Events will fail to be published, with a message like:

time="2024-08-29T17:04:39Z" level=warning msg="Event could not be sent: Event \"my-application.17f041de2f74d240\" is invalid: involvedObject.namespace: Invalid value: \"the-application-namespace\": does not match event.namespace" application=my-application

To Reproduce
Steps to reproduce the behavior:

  • Configure an Application in another namespace than where the argocd-image-updater is running
  • Configure update method argocd (not using kubernetes client, this is currently broken I think, but that's another issue)
  • Trigger an update, that requires an Event to be published

Result is that the event is not published, this warning is logged instead.

Expected behavior
Events are published

Additional context
This is related to recent functionality on Apps in other namespaces.
Looking at the code, it seems to boil down to the kubernetes client being initiated in a particular namespace, which is not matching the Application.

I have a branch that resolves this issue (for me at least), which I will link to this issue for review.

Version
v0.14.0 and or built from master.

Logs
See above
@jortkoopmans jortkoopmans added the bug Something isn't working label Aug 30, 2024
jortkoopmans added a commit to EnergyExchangeEnablersBV/argocd-image-updater that referenced this issue Aug 30, 2024
@jortkoopmans
Sync namespace for Event to the Application namespace (argoproj-labs#847
732840c 
)
@jortkoopmans jortkoopmans mentioned this issue Aug 30, 2024
Merged
@chengfang
Copy link
Collaborator

The other issue related to 'apps in any namespace': #601

jortkoopmans added a commit to EnergyExchangeEnablersBV/argocd-image-updater that referenced this issue Sep 1, 2024
@jortkoopmans
Sync namespace for Event to the Application namespace (argoproj-labs#847
fd60c85 
)

Signed-off-by: Jort Koopmans <jort.koopmans@entrnce.com>
jortkoopmans added a commit to EnergyExchangeEnablersBV/argocd-image-updater that referenced this issue Sep 2, 2024
@jortkoopmans
Sync namespace for Event to the Application namespace (argoproj-labs#847
234773c 
)

Signed-off-by: Jort Koopmans <jort.koopmans@entrnce.com>
jannfis pushed a commit that referenced this issue Sep 6, 2024
@jortkoopmans
feat: Sync namespace for Event to the Application namespace (#847) (#848
5990a9b 
)

Signed-off-by: Jort Koopmans <jort.koopmans@entrnce.com>
@jannfis
Copy link
Contributor

jannfis commented Sep 6, 2024

Closed by #848

@jannfis jannfis closed this as completed Sep 6, 2024
@yu-croco yu-croco mentioned this issue Oct 23, 2024
Closed
1 task
Tchoupinax pushed a commit to Tchoupinax/argocd-image-updater that referenced this issue Oct 23, 2024
@jortkoopmans @Tchoupinax
feat: Sync namespace for Event to the Application namespace (argoproj…
1a79b0c 
…-labs#847) (argoproj-labs#848)

Signed-off-by: Jort Koopmans <jort.koopmans@entrnce.com>
Signed-off-by: Tchoupinax <corentinfiloche@hotmail.fr>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@jortkoopmans @chengfang @jannfis