Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[charts/argo-cd] Initial testing tests for validating Helm chart outputs # #183

Closed
wants to merge 6 commits into from
Closed

Conversation

seanson
Copy link
Contributor

@seanson seanson commented Dec 8, 2019

Investigation for #179

Checklist:

  • I have update the chart version in Chart.yaml following Semantic Versioning.
  • Any new values are backwards compatible and/or have sensible default.
  • I have followed the testing instructions in the contributing guide.
  • I have signed the CLA and the build is green.
  • I will test my changes again once merged to master and published.

Changes are automatically published when merged to master. They are not published on branches.

This is a sample of the tests I've been writing as I work through the Argo Helm issues. I've found it particularly helpful for verifying initial issues and fixes and have added some comments around the validation I did for #171 and #181

It depends on an external project I've been working on in my spare time, which is a Terratest docker image with pre-populated golang tests. Source is here: https://github.com/seanson/terratest-helm-tester

I'm keen to get some feedback around how these tests work and if we think it is a workable flow in the future.

@seanson seanson marked this pull request as ready for review March 9, 2020 10:42
@seanson seanson requested a review from spencergilbert as a code owner March 9, 2020 10:42
@alexec alexec closed this Mar 31, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
argo-cd enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants