Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[charts/argo-cd] add support of custom environment variables #181

Merged
merged 3 commits into from
Dec 5, 2019

Conversation

cryptobioz
Copy link
Contributor

@cryptobioz cryptobioz commented Dec 4, 2019

Checklist:

  • I have update the chart version in Chart.yaml following Semantic Versioning.
  • Any new values are backwards compatible and/or have sensible default.
  • I have followed the testing instructions in the contributing guide.
  • I have signed the CLA and the build is green.
  • I will test my changes again once merged to master and published.

Changes are automatically published when merged to master. They are not published on branches.

@claassistantio
Copy link

claassistantio commented Dec 4, 2019

CLA assistant check
All committers have signed the CLA.

Signed-off-by: Léo Depriester <leo.depriester@camptocamp.com>
@cryptobioz cryptobioz force-pushed the feature/argocd/extra-env-var branch from 24978ea to 02c8493 Compare December 5, 2019 16:57
@seanson seanson merged commit 3a2c980 into argoproj:master Dec 5, 2019
@seanson
Copy link
Contributor

seanson commented Dec 5, 2019

Tested locally, all good! Thanks for the PR @cryptobioz!

@cryptobioz
Copy link
Contributor Author

Thanks @seanson!

nouseforaname pushed a commit to nouseforaname/argo-helm that referenced this pull request Jan 29, 2020
…j#181)

Signed-off-by: Léo Depriester <leo.depriester@camptocamp.com>
* Fix controller env path
* Updating chart bump to patch as this is a backwards compatible change
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants