Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: docs site version selector broken #18378

Merged
merged 1 commit into from
Jun 18, 2024
Merged

fix: docs site version selector broken #18378

merged 1 commit into from
Jun 18, 2024

Conversation

yyzxw
Copy link
Contributor

@yyzxw yyzxw commented May 23, 2024 •
edited
Loading

Fixes #18239

image

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
  • The title of the PR states what changed and the related issues number (used for the release note).
  • The title of the PR conforms to the Toolchain Guide
  • I've included "Closes [ISSUE #]" or "Fixes [ISSUE #]" in the description to automatically close the associated issue.
  • I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
  • Does this PR require documentation updates?
  • I've updated documentation as required by this PR.
  • I have signed off all my commits as required by DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My build is green (troubleshooting builds).
  • My new feature complies with the feature status guidelines.
  • I have added a brief description of why this PR is necessary and/or what this PR solves.
  • Optional. My organization is added to USERS.md.
  • Optional. For bug fixes, I've indicated what older releases this fix should be cherry-picked into (this may or may not happen depending on risk/complexity).

@yyzxw yyzxw requested review from a team as code owners May 23, 2024 06:17
@yyzxw
Copy link
Contributor Author

yyzxw commented May 24, 2024

cc @sentientmonkey @farcaller

agaudreault
agaudreault requested changes May 29, 2024
View reviewed changes
Copy link
Member

@agaudreault agaudreault left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@yyzxw Thanks for the PR! I think some css changes are needed as well. From your screenshot, there seems to be a lot of extra padding in the dropdown.

Also, if you can validate that your PR does not duplicate the banner message, or use the new one, we can close 2 issues from this PR. See #18407

@christianh814
Copy link
Member

@yyzxw Did you have a chance to take a look at @agaudreault's suggestions?

@yyzxw yyzxw force-pushed the fix/version-selector-broken branch from afe2f74 to b931c94 Compare June 17, 2024 15:36
@yyzxw
Copy link
Contributor Author

yyzxw commented Jun 17, 2024

@agaudreault yes, Also fixed #18407 now.

@yyzxw
fix: docs site version selector broken
9a149f8 
Signed-off-by: xiaowu.zhu <xiaowu.zhu@daocloud.io>
Signed-off-by: root <root@daocloud.io>
@yyzxw yyzxw force-pushed the fix/version-selector-broken branch from b931c94 to 9a149f8 Compare June 17, 2024 15:39
agaudreault
agaudreault approved these changes Jun 17, 2024
View reviewed changes
Copy link
Member

@agaudreault agaudreault left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not so sure how we can test in local, but the version selector now works!

ishitasequeira
ishitasequeira approved these changes Jun 18, 2024
View reviewed changes
Copy link
Member

@ishitasequeira ishitasequeira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!! Thanks @yyzxw!!

@ishitasequeira ishitasequeira merged commit 9f0d2a8 into argoproj:master Jun 18, 2024
23 checks passed
@crenshaw-dev
Copy link
Member

/cherry-pick release-2.11

gcp-cherry-pick-bot bot pushed a commit that referenced this pull request Jun 18, 2024
@yyzxw
fix: docs site version selector broken (#18378)
0d3f6bc 
Signed-off-by: xiaowu.zhu <xiaowu.zhu@daocloud.io>
Signed-off-by: root <root@daocloud.io>
@gcp-cherry-pick-bot gcp-cherry-pick-bot bot mentioned this pull request Jun 18, 2024
Merged
crenshaw-dev pushed a commit that referenced this pull request Jun 18, 2024
@gcp-cherry-pick-bot @yyzxw
fix: docs site version selector broken (#18378) (#18724)
5fd645f 
Signed-off-by: xiaowu.zhu <xiaowu.zhu@daocloud.io>
Signed-off-by: root <root@daocloud.io>
Co-authored-by: yyzxw <34639446+yyzxw@users.noreply.github.com>
@ft-jasong ft-jasong mentioned this pull request Jun 21, 2024
Open
3 tasks
ggjulio pushed a commit to ggjulio/argo-cd that referenced this pull request Jul 21, 2024
@yyzxw @ggjulio
fix: docs site version selector broken (argoproj#18378)
00f69d2 
Signed-off-by: xiaowu.zhu <xiaowu.zhu@daocloud.io>
Signed-off-by: root <root@daocloud.io>
jsolana pushed a commit to jsolana/argo-cd that referenced this pull request Jul 24, 2024
@yyzxw
fix: docs site version selector broken (argoproj#18378)
e04d78a 
Signed-off-by: xiaowu.zhu <xiaowu.zhu@daocloud.io>
Signed-off-by: root <root@daocloud.io>
Signed-off-by: Javier Solana <javier.solana@cabify.com>
Signed-off-by: Javier Solana <javier.solana@cabify.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@agaudreault agaudreault agaudreault approved these changes

@ishitasequeira ishitasequeira ishitasequeira approved these changes

@christianh814 christianh814 christianh814 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
Argo CD Roadmap
Status: Completed
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Version selector in website is broken
5 participants
@yyzxw @christianh814 @crenshaw-dev @ishitasequeira @agaudreault