-
Notifications
You must be signed in to change notification settings - Fork 189
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add new Kubernetes Secret backend #521
feat: Add new Kubernetes Secret backend #521
Conversation
4af0cf8
to
98b7116
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the contribution @dennislapchenko! My biggest question is around the idea of the "default" secret and whether it is necessary.
Signed-off-by: Dennis Lapchenko <dennis.lapchenko@gmail.com>
16a8c86
to
aeeedf1
Compare
Cheers @werne2j , I have removed the "default" secret and updated the documentation with [tested] namespace examples. |
hey @werne2j , any info on when this can be released? Or any other comments please? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Codecov Report
@@ Coverage Diff @@
## main #521 +/- ##
==========================================
- Coverage 71.06% 70.65% -0.42%
==========================================
Files 25 26 +1
Lines 1911 1949 +38
==========================================
+ Hits 1358 1377 +19
- Misses 455 472 +17
- Partials 98 100 +2
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @dennislapchenko!
Any chance we could cut a new release to close #516 . Super excited to use this! |
Agree! Maybe you can accelerate it if you submit a 1.16 release PR with version bumps (they did similar with 1.15) |
Description
Add a new backend: Kubernetes Secret.
Fixes: #516
Checklist
Please make sure that your PR fulfills the following requirements:
go mod tidy -compat=1.17
to ensure only the minimum is pulled in.Type of Change