-
Notifications
You must be signed in to change notification settings - Fork 189
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
feat: Add new Kubernetes Secret backend
Signed-off-by: Dennis Lapchenko <dennis.lapchenko@gmail.com>
- Loading branch information
1 parent
2f3a187
commit 98b7116
Showing
8 changed files
with
268 additions
and
31 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,70 @@ | ||
package backends | ||
|
||
import ( | ||
"github.com/argoproj-labs/argocd-vault-plugin/pkg/kube" | ||
"github.com/argoproj-labs/argocd-vault-plugin/pkg/utils" | ||
"github.com/pkg/errors" | ||
) | ||
|
||
var useDefaultSecret = func(s string) bool { return s == "default" || s == "~" } | ||
|
||
type kubeSecretsClient interface { | ||
ReadSecretData(string) (map[string][]byte, error) | ||
} | ||
|
||
// KubernetesSecret is a struct for working with a Kubernetes Secret backend | ||
type KubernetesSecret struct { | ||
secretName string | ||
client kubeSecretsClient | ||
} | ||
|
||
// NewKubernetesSecret returns a new Kubernetes Secret backend. | ||
func NewKubernetesSecret(secretName string) *KubernetesSecret { | ||
return &KubernetesSecret{ | ||
secretName: secretName, | ||
} | ||
} | ||
|
||
// Login initiates kubernetes client | ||
func (k *KubernetesSecret) Login() error { | ||
localClient, err := kube.NewClient() | ||
if err != nil { | ||
return errors.Wrap(err, "Failed to perform login for kubernetes secret backend") | ||
} | ||
k.client = localClient | ||
return nil | ||
} | ||
|
||
// GetSecrets gets secrets from Kubernetes Secret and returns the formatted data | ||
func (k *KubernetesSecret) GetSecrets(path string, version string, annotations map[string]string) (map[string]interface{}, error) { | ||
secretName := path | ||
if useDefaultSecret(path) { | ||
secretName = k.secretName | ||
} | ||
utils.VerboseToStdErr("K8s Secret getting secret: %s", secretName) | ||
|
||
data, err := k.client.ReadSecretData(secretName) | ||
if err != nil { | ||
return nil, err | ||
} | ||
|
||
out := make(map[string]interface{}, len(data)) | ||
for k, v := range data { | ||
out[k] = string(v) | ||
} | ||
|
||
utils.VerboseToStdErr("K8s Secret get secret response: %v", out) | ||
return out, nil | ||
} | ||
|
||
// GetIndividualSecret will get the specific secret (placeholder) from the Kubernetes Secret backend | ||
// Kubernetes Secrets can only be wholly read, | ||
// So, we use GetSecrets and extract the specific placeholder we want | ||
func (k *KubernetesSecret) GetIndividualSecret(kvpath, secret, version string, annotations map[string]string) (interface{}, error) { | ||
utils.VerboseToStdErr("K8s Secret getting secret %s and key %s", kvpath, secret) | ||
data, err := k.GetSecrets(kvpath, version, annotations) | ||
if err != nil { | ||
return nil, err | ||
} | ||
return data[secret], nil | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,75 @@ | ||
package backends | ||
|
||
import ( | ||
"reflect" | ||
"testing" | ||
) | ||
|
||
func newMockK8sClient(vals map[string]string, err error) *mockK8sClient { | ||
encoded := make(map[string][]byte) | ||
for k, v := range vals { | ||
encoded[k] = []byte(v) | ||
} | ||
return &mockK8sClient{ | ||
response: encoded, | ||
err: err, | ||
} | ||
} | ||
|
||
type mockK8sClient struct { | ||
response map[string][]byte | ||
err error | ||
} | ||
|
||
func (m *mockK8sClient) ReadSecretData(path string) (map[string][]byte, error) { | ||
return m.response, m.err | ||
} | ||
|
||
func TestKubernetesSecretGetSecrets(t *testing.T) { | ||
sm := NewKubernetesSecret("test") | ||
sm.client = newMockK8sClient(map[string]string{ | ||
"test-secret": "current-value", | ||
"test2": "bar", | ||
}, nil) | ||
|
||
t.Run("Get secrets", func(t *testing.T) { | ||
|
||
data, err := sm.GetSecrets("test", "", map[string]string{}) | ||
if err != nil { | ||
t.Fatalf("expected 0 errors but got: %s", err) | ||
} | ||
|
||
expected := map[string]interface{}{ | ||
"test-secret": "current-value", | ||
"test2": "bar", | ||
} | ||
|
||
if !reflect.DeepEqual(expected, data) { | ||
t.Errorf("expected: %s, got: %s.", expected, data) | ||
} | ||
}) | ||
|
||
t.Run("GetIndividualSecret", func(t *testing.T) { | ||
secret, err := sm.GetIndividualSecret("test", "test2", "", map[string]string{}) | ||
if err != nil { | ||
t.Fatalf("expected 0 errors but got: %s", err) | ||
} | ||
|
||
expected := "bar" | ||
|
||
if !reflect.DeepEqual(expected, secret) { | ||
t.Errorf("expected: %s, got: %s.", expected, secret) | ||
} | ||
}) | ||
|
||
t.Run("GetIndividualSecretNotFound", func(t *testing.T) { | ||
secret, err := sm.GetIndividualSecret("test", "22test2", "", map[string]string{}) | ||
if err != nil { | ||
t.Fatalf("expected 0 errors but got: %s", err) | ||
} | ||
|
||
if secret != nil { | ||
t.Errorf("expected: %s, got: %s.", "nil", secret) | ||
} | ||
}) | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters