feat: Introduce a new CR for managing Notifications Configuration #1264
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tifications-cm Signed-off-by: iam-veeramalla <abhishek.veeramalla@gmail.com>
Signed-off-by: iam-veeramalla <abhishek.veeramalla@gmail.com>
Signed-off-by: iam-veeramalla <abhishek.veeramalla@gmail.com>
Signed-off-by: iam-veeramalla <abhishek.veeramalla@gmail.com>
jaideepr97
reviewed
Feb 26, 2024
Signed-off-by: iam-veeramalla <abhishek.veeramalla@gmail.com>
jaideepr97
approved these changes
Feb 26, 2024
There was a problem hiding this comment.
Locally tested it, seems to work fine
LGTM
Thanks a lot @iam-veeramalla !
svghadi
reviewed
Feb 27, 2024
svghadi
approved these changes
Feb 27, 2024
Signed-off-by: iam-veeramalla <abhishek.veeramalla@gmail.com>
Signed-off-by: iam-veeramalla <abhishek.veeramalla@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
What does this PR do / why we need it:
Fixes #1265
Closes #1265
Have you updated the necessary documentation?
Which issue(s) this PR fixes:
Fixes #1265
How to test changes / Special notes to the reviewer:
argocd-notifications-cmNote: This PR also updates docs to provide Instructions on how to update the
NotificationsConfigurationCR.