Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a new custom resource to manage the argocd-notifications-cm #1265

Closed
iam-veeramalla opened this issue Feb 26, 2024 · 1 comment · Fixed by #1264
Closed

Add a new custom resource to manage the argocd-notifications-cm #1265

iam-veeramalla opened this issue Feb 26, 2024 · 1 comment · Fixed by #1264

Comments

@iam-veeramalla
Copy link
Collaborator

iam-veeramalla commented Feb 26, 2024

Is your feature request related to a problem? Please describe.
Currently, Argo CD Operator supports Notifications as Beta. One of the primary reasons for this is, Argo CD Operator does not manage the configuration(templates, triggers, services, subscriptions e.t.c.,.) of the the argocd-notifications-cm.

Triggers, Templates, Services and Subscriptions can be so huge at times that it creates a bad user experience if they are added to the Argo CD CR and managed by the Argo CD Reconciler of the Argo CD Operator.

Describe the solution you'd like

  • It is better to create a new CR - NotificationsConfiguration that can be used by the Users to update the their custom templates, triggers e.t.c.,.
  • A new reconciler will watch this CR to update the argocd-notifications-cm.
  • argocd-notifications-cm should be created with default triggers, templates e.t.c.,. OOTB.

Additional context
Sample NotificationsConfiguration resource

apiVersion: argoproj.io/v1alpha1
kind: NotificationsConfiguration
metadata:
 name: default-notifications-configuration
spec:
 triggers:
  trigger.on-sync-status-unknown: |
    - when: app.status.sync.status == 'Unknown'
      send: [my-custom-template]
 templates:
  template.my-custom-template: |
    message: |
      Application details: {{.context.argocdUrl}}/applications/{{.app.metadata.name}}.
@GijsvanDulmen
Copy link

Sorry for replying on a close issue. But does this feature also work with extremely large created argocd notifications configmaps? We have a situation where we needed to do a server side apply of the configmap because it became large. Does the shift to CRD's still allow us for those large configmaps?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants