feat: Sync namespace for Event to the Application namespace (#847) #848
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jortkoopmans
requested review from
jannfis,
chengfang and
pasha-codefresh
as code owners
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #848 +/- ##
=======================================
Coverage 73.43% 73.43%
=======================================
Files 31 31
Lines 3136 3136
=======================================
Hits 2303 2303
Misses 695 695
Partials 138 138 ☔ View full report in Codecov by Sentry. |
jannfis
reviewed
Aug 30, 2024
jortkoopmans
force-pushed
the
bugfix/847_CreateApplicationEvent_namespace_failure
branch
from
732840c
to
fd60c85
Compare
jortkoopmans
force-pushed
the
bugfix/847_CreateApplicationEvent_namespace_failure
branch
from
fd60c85
to
234773c
Compare
…pace) Signed-off-by: Jort Koopmans <jort.koopmans@entrnce.com>
Thank you for the quick feedback. |
jannfis
changed the title
jannfis
approved these changes
Sep 6, 2024
|
@jortkoopmans can you please take a look at the regression reported in issue #859? Thanks. |
Tchoupinax
pushed a commit
to Tchoupinax/argocd-image-updater
that referenced
this pull request
Oct 23, 2024
…-labs#847) (argoproj-labs#848) Signed-off-by: Jort Koopmans <jort.koopmans@entrnce.com> Signed-off-by: Tchoupinax <corentinfiloche@hotmail.fr>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sync namespace for Event to the Application namespace (#847)
Note that this does assume that the kubernetes client has permissions to create Events on the particular namespace (this typically depends on cluster RBAC)