Assign "other" request type for newline-only diffs #67
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `testify` Go packages use the "Yoda condition"-style argument order: expected, actual. If the assertions reverse the order of the arguments, the test failure output becomes very confusing. Even though `assert.ElementsMatch()` doesn't treat the order of the arguments specially, it is best to be consistent with the order.
In order to make the system as lenient as possible in regards to submission format, newline changes to the list are ignored (with the exception of final newline removal). For this reason, a PR consisting solely of changes to the newlines in the list results in a null list of URLs, as would be expected. The problem was that these PRs were assigned a "modification" type. A workflow job matrix is used to check the list of URLs generated from a "modification" request "update" mode to see whether they are still compliant with the requirements in order to triage modification requests before the registry maintainer does the final manual review of the PR. GitHub Actions does not allow zero length job matrices, and anyway this sort of PR does not match with the meaning we have assigned the "modification" type. The "other" type is most appropriate for this type of PR. "other" type requests are also manually reviewed, but without the automated triage.
per1234
added
type: imperfection
Codecov Report
@@ Coverage Diff @@
## main #67 +/- ##
==========================================
+ Coverage 28.62% 29.15% +0.52%
==========================================
Files 1 1
Lines 269 271 +2
==========================================
+ Hits 77 79 +2
Misses 188 188
Partials 4 4
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
silvanocerza
approved these changes
Aug 26, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to make the system as lenient as possible in regards to submission format, newline changes to the list are ignored (with the exception of final newline removal). For this reason, a PR consisting solely of changes to the newlines in the list results in a null list of URLs, as would be expected.
The problem was that these PRs were assigned a "modification" type. A workflow job matrix is used to check the list of URLs generated from a "modification" request "update" mode to see whether they are still compliant with the requirements in order to triage modification requests before the registry maintainer does the final manual review of the PR.
GitHub Actions does not allow zero length job matrices, and anyway this sort of PR does not match with the meaning we have assigned the "modification" type. The "other" type is most appropriate for this type of PR. "other" type requests are also manually reviewed, but without the automated triage which is not relevant to these requests.