Skip to content

Bump arduino/library-manager-submission-parser version #408

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 26, 2021

Conversation

per1234
Copy link
Contributor

@per1234 per1234 commented Aug 26, 2021

A new release of the arduino/library-manager-submission-parser tool used by the "Manage PRs" workflow has been made.
This release fixes (arduino/library-registry-submission-parser#67) a bug that caused pull requests that consisted only of newlines to be incorrectly classified as "modification", resulting in an unexpected failure of the workflow run due to there being no library URLs to populate the check-submissions job matrix:

https://github.com/arduino/library-registry/actions/runs/1167544288 (#404)

Error when evaluating 'strategy' for job 'check-submissions'. (Line: 219, Col: 21): Unexpected value ''

These pull requests will now be assigned the appropriate "other" request type and the workflow run will pass as expected,
requesting the necessary manual review from a maintainer.

Demo of the same diff handled correctly by the updated parser tool:
https://github.com/per1234/library-registry/runs/3429023708#step:2:119

Full test procedure run through with the new parser:
per1234#26

A new release of the `arduino/library-manager-submission-parser` tool used by the "Manage PRs" workflow has been made.
This release fixes a bug that caused pull requests that consisted only of newlines to be incorrectly classified as
"modification", resulting in an unexpected failure of the workflow run due to there being no library URLs to populate the
`check-submissions` job matrix:

```
Error when evaluating 'strategy' for job 'check-submissions'. (Line: 219, Col: 21): Unexpected value ''
```

These pull requests will now be assigned the appropriate "other" request type and the workflow run will pass as expected,
requesting the necessary manual review from a maintainer.
@per1234 per1234 added type: bug topic: code Related to content of the project itself labels Aug 26, 2021
@per1234 per1234 requested review from silvanocerza and rsora August 26, 2021 10:43
@github-actions
Copy link
Contributor

Hi @per1234.
Your pull request has been detected as something other than a Library Manager submission.
A maintainer will need to review it before it can be merged.

If you intended to submit a library, please check the instructions and update your pull request if necessary:
https://github.com/arduino/library-registry/blob/main/README.md#instructions

@github-actions github-actions bot added other and removed type: bug topic: code Related to content of the project itself labels Aug 26, 2021
@per1234 per1234 merged commit 7b41313 into arduino:main Aug 26, 2021
@per1234 per1234 deleted the bump-parser branch August 26, 2021 11:05
@per1234 per1234 added topic: code Related to content of the project itself type: bug labels Aug 26, 2021
@rsora rsora added the topic: other Something other than a library list request label Sep 22, 2021
@per1234 per1234 self-assigned this Nov 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic: code Related to content of the project itself topic: other Something other than a library list request type: imperfection Perceived defect in any part of project
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants