Skip to content

[breaking] fix: remove tree config lookup #2085

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Feb 27, 2023
Merged

[breaking] fix: remove tree config lookup #2085

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
4d787f1
revert: removed config file lookup in cwd and parents
Feb 22, 2023
8aec70c
test: remove obsolete case
Feb 23, 2023
6c5b706
fix: old function name
Feb 23, 2023
d9d32a7
test: use command line flag in tests
Feb 23, 2023
81b52c4
docs: removed tree config lookup docs
Feb 24, 2023
bf6da0a
docs: modified upgrading.md
Feb 24, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
test: remove obsolete case
  • Loading branch information
Luca Bianconi committed Feb 23, 2023
commit 8aec70c91c55a24f1e9c47bbf4b606eb04eecfa7
23 changes: 0 additions & 23 deletions configuration/configuration_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,27 +71,4 @@ func TestFindConfigFile(t *testing.T) {

configFile = FindConfigFileInArgs([]string{})
require.Equal(t, "", configFile)

// Create temporary directories
tmp := tmpDirOrDie()
defer os.RemoveAll(tmp)
target := filepath.Join(tmp, "foo", "bar", "baz")
os.MkdirAll(target, os.ModePerm)
require.Nil(t, os.Chdir(target))

// Create a config file
f, err := os.Create(filepath.Join(target, "..", "..", "arduino-cli.yaml"))
require.Nil(t, err)
f.Close()

configFile = FindConfigFileInArgs([]string{})
require.Equal(t, filepath.Join(tmp, "foo", "arduino-cli.yaml"), configFile)

// Create another config file
f, err = os.Create(filepath.Join(target, "arduino-cli.yaml"))
require.Nil(t, err)
f.Close()

configFile = FindConfigFileInArgs([]string{})
require.Equal(t, filepath.Join(target, "arduino-cli.yaml"), configFile)
}