-
-
Notifications
You must be signed in to change notification settings - Fork 385
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[breaking] fix: remove tree config lookup #2085
Conversation
Codecov ReportBase: 36.56% // Head: 36.52% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #2085 +/- ##
==========================================
- Coverage 36.56% 36.52% -0.04%
==========================================
Files 229 229
Lines 19538 19526 -12
==========================================
- Hits 7144 7132 -12
- Misses 11555 11556 +1
+ Partials 839 838 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
Shouldn't this be marked as breaking compatibility? And set to close #758? |
468794c
to
384cd3d
Compare
@matthijskooijman yes, that's correct. It will be marked as such once it leaves the draft mode, at the latest. |
b7ef8b7
to
7bf2ec8
Compare
7bf2ec8
to
d9d32a7
Compare
a123e56
to
bf6da0a
Compare
Please check if the PR fulfills these requirements
See how to contribute
before creating one)
our contributing guidelines
UPGRADING.md
has been updated with a migration guide (for breaking changes)configuration.schema.json
updated if new parameters are added.What kind of change does this PR introduce?
Dismiss the automatic config file lookup in the current working directory and its parents.
What is the current behavior?
When the user does not specify a configuration file, the presence of one is checked in the current working directory and iteratively from the closest parent directory to the root.
What is the new behavior?
The described config file lookup is dropped. It becomes possible to specify a configuration file only by the command line flag
--config-file
or by changing the arduino data directory.Does this PR introduce a breaking change, and is titled accordingly?
Yes, applications relying on the previous silent current working directory and parents lookup will be disregarded.
Other information
Fixes #758