[skip-changelog] Remove empty object from the output of grpc commands #2057
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MatteoPologruto
added
topic: code
Codecov ReportBase: 36.64% // Head: 36.67% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #2057 +/- ##
==========================================
+ Coverage 36.64% 36.67% +0.03%
==========================================
Files 228 228
Lines 19405 19384 -21
==========================================
Hits 7110 7110
+ Misses 11463 11442 -21
Partials 832 832
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
MatteoPologruto
force-pushed
the
empty-object-removal
branch
from
d6faa63
to
8406f9a
Compare
cmaglie
approved these changes
Feb 2, 2023
Bikappa
reviewed
Feb 2, 2023
| return convertErrorToRPCStatus(err) | ||
| } | ||
| return stream.Send(&rpc.LibraryInstallResponse{}) | ||
| return convertErrorToRPCStatus(err) |
There was a problem hiding this comment.
Can a similar approach be applied to other stream.Send()? Like the return at the end of the PlatformInstall command above.
Also I think we should also add some test to avoid regression
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
See how to contribute
before creating one)
our contributing guidelines
UPGRADING.mdhas been updated with a migration guide (for breaking changes)What kind of change does this PR introduce?
gRPC code imperfection fix
What is the current behavior?
Some gRPC commands like
UpdateLibrariesIndexstream an empty object after a successful execution.What is the new behavior?
The empty object has been removed.
Does this PR introduce a breaking change, and is titled accordingly?
No
Close #2046