Skip to content

Commit

Permalink
Remove empty object from the output of grpc commands
Browse files Browse the repository at this point in the history
  • Loading branch information
MatteoPologruto committed Jan 31, 2023
1 parent 60a8aa9 commit d6faa63
Showing 1 changed file with 7 additions and 28 deletions.
35 changes: 7 additions & 28 deletions commands/daemon/daemon.go
Original file line number Diff line number Diff line change
Expand Up @@ -159,10 +159,7 @@ func (s *ArduinoCoreServerImpl) UpdateLibrariesIndex(req *rpc.UpdateLibrariesInd
err := commands.UpdateLibrariesIndex(stream.Context(), req,
func(p *rpc.DownloadProgress) { stream.Send(&rpc.UpdateLibrariesIndexResponse{DownloadProgress: p}) },
)
if err != nil {
return convertErrorToRPCStatus(err)
}
return stream.Send(&rpc.UpdateLibrariesIndexResponse{})
return convertErrorToRPCStatus(err)
}

// Create FIXMEDOC
Expand Down Expand Up @@ -357,10 +354,7 @@ func (s *ArduinoCoreServerImpl) LibraryInstall(req *rpc.LibraryInstallRequest, s
func(p *rpc.DownloadProgress) { stream.Send(&rpc.LibraryInstallResponse{Progress: p}) },
func(p *rpc.TaskProgress) { stream.Send(&rpc.LibraryInstallResponse{TaskProgress: p}) },
)
if err != nil {
return convertErrorToRPCStatus(err)
}
return stream.Send(&rpc.LibraryInstallResponse{})
return convertErrorToRPCStatus(err)
}

// LibraryUpgrade FIXMEDOC
Expand All @@ -370,21 +364,15 @@ func (s *ArduinoCoreServerImpl) LibraryUpgrade(req *rpc.LibraryUpgradeRequest, s
func(p *rpc.DownloadProgress) { stream.Send(&rpc.LibraryUpgradeResponse{Progress: p}) },
func(p *rpc.TaskProgress) { stream.Send(&rpc.LibraryUpgradeResponse{TaskProgress: p}) },
)
if err != nil {
return convertErrorToRPCStatus(err)
}
return stream.Send(&rpc.LibraryUpgradeResponse{})
return convertErrorToRPCStatus(err)
}

// LibraryUninstall FIXMEDOC
func (s *ArduinoCoreServerImpl) LibraryUninstall(req *rpc.LibraryUninstallRequest, stream rpc.ArduinoCoreService_LibraryUninstallServer) error {
err := lib.LibraryUninstall(stream.Context(), req,
func(p *rpc.TaskProgress) { stream.Send(&rpc.LibraryUninstallResponse{TaskProgress: p}) },
)
if err != nil {
return convertErrorToRPCStatus(err)
}
return stream.Send(&rpc.LibraryUninstallResponse{})
return convertErrorToRPCStatus(err)
}

// LibraryUpgradeAll FIXMEDOC
Expand All @@ -393,10 +381,7 @@ func (s *ArduinoCoreServerImpl) LibraryUpgradeAll(req *rpc.LibraryUpgradeAllRequ
func(p *rpc.DownloadProgress) { stream.Send(&rpc.LibraryUpgradeAllResponse{Progress: p}) },
func(p *rpc.TaskProgress) { stream.Send(&rpc.LibraryUpgradeAllResponse{TaskProgress: p}) },
)
if err != nil {
return convertErrorToRPCStatus(err)
}
return stream.Send(&rpc.LibraryUpgradeAllResponse{})
return convertErrorToRPCStatus(err)
}

// LibraryResolveDependencies FIXMEDOC
Expand Down Expand Up @@ -429,10 +414,7 @@ func (s *ArduinoCoreServerImpl) ZipLibraryInstall(req *rpc.ZipLibraryInstallRequ
stream.Context(), req,
func(p *rpc.TaskProgress) { stream.Send(&rpc.ZipLibraryInstallResponse{TaskProgress: p}) },
)
if err != nil {
return convertErrorToRPCStatus(err)
}
return stream.Send(&rpc.ZipLibraryInstallResponse{})
return convertErrorToRPCStatus(err)
}

// GitLibraryInstall FIXMEDOC
Expand All @@ -441,10 +423,7 @@ func (s *ArduinoCoreServerImpl) GitLibraryInstall(req *rpc.GitLibraryInstallRequ
stream.Context(), req,
func(p *rpc.TaskProgress) { stream.Send(&rpc.GitLibraryInstallResponse{TaskProgress: p}) },
)
if err != nil {
return convertErrorToRPCStatus(err)
}
return stream.Send(&rpc.GitLibraryInstallResponse{})
return convertErrorToRPCStatus(err)
}

// EnumerateMonitorPortSettings FIXMEDOC
Expand Down

0 comments on commit d6faa63

Please sign in to comment.