CPX fixes: add &MI_00 to all devices so CPLAYBOOT is not hidden on Windows 10 #338
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@cmaglie We just found out that webUSB beta is available (again) for MakeCode, and this driver will interfere with that. We'll have another PR that fixes that soon, if the 1.6.20 release is not imminent. We need to suppress Circuit Playground Express driver installation completely on Windows 10, probably in the The changes in this PR are still fine: the .inf is an improvement in general on the previous one. tagging @ladyada |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
File naming has also been normalized to match the other drivers in this directory: all lower case, and the
.infand.catfiles now have the same name.Fixes #336.
@ladyada and I have tested this on Windows 7 and Windows 10.
Could you make a new minor release after accepting this PR? Thanks!
(EDIT: also version number of driver has been bumped and made more rational)