Do not install CPX drivers on Windows 10 #60
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ladyada also ping on this, to prevent further CPX problems on Windows 7. Essentially identical PR submitted to arduino/ArduinoCore-samd |
dhalbert
force-pushed
the
no-win10-cpx-adafruit
branch
3 times, most recently
from
debc739 to
285ca1b
Compare
|
@ladyada ping on the touch-up fixes on this PR, that fix WebUSB null driver install on Win7 |
|
yeep sorry |
|
ok just checked on win 10 and post_install def does not install anything and quits when it should |
|
tested on win 7, installed CPX drivers right! |
ladyada
approved these changes
Nov 26, 2018
|
@ladyada should I make an Arduino release out of this? (have to remember how to do that) |
|
yah do you want to learn how? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These are the identical changes pushed as arduino#346 and arduino#338, to prevent the CPX driver installer from running on Windows 10, to fix arduino#336.
As of this moment arduino/ArduinoCore-samd hasn't been released as a new version yet, but we should anticipate that by fixing this in our own BSP now.