Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove struct constraint in SmartEnumNameConverter #214

Merged
merged 1 commit into from
Jan 28, 2022

Conversation

bfriesen
Copy link
Contributor

This fixes the same problem as described by #101 and fixed by #106, except for SmartEnumNameConverter instead of SmartEnumValueConverter.

@bfriesen
Copy link
Contributor Author

(sorry about the force push; I had committed under the wrong email address)

@ardalis ardalis merged commit 77329a1 into ardalis:main Jan 28, 2022
@ardalis
Copy link
Owner

ardalis commented Jan 28, 2022

Thanks!

@bfriesen
Copy link
Contributor Author

bfriesen commented Feb 3, 2022

@ardalis Any idea when this will be published? There's not big rush - I've currently got the SmartEnumNameConverter class copy/pasted into my project and everything works fine. But I'll want to change that to a package reference whenever you publish, hence my curiosity.

@ardalis
Copy link
Owner

ardalis commented Feb 3, 2022

Hoping to have time to finish fixing things, clear out all issues/PRs, and publish this month.

@bfriesen
Copy link
Contributor Author

bfriesen commented Feb 4, 2022

Excellent, looking forward to it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants