Remove struct constraint

ardalis · Jan 28, 2022 · 22b9ac6 · 22b9ac6
1 parent adf6cb7
commit 22b9ac6
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 2 deletions.
diff --git a/src/SmartEnum.JsonNet/SmartEnumNameConverter.cs b/src/SmartEnum.JsonNet/SmartEnumNameConverter.cs
@@ -5,7 +5,7 @@ namespace Ardalis.SmartEnum.JsonNet
 
     public class SmartEnumNameConverter<TEnum, TValue> : JsonConverter<TEnum>
         where TEnum : SmartEnum<TEnum, TValue>
-        where TValue : struct, IEquatable<TValue>, IComparable<TValue>
+        where TValue : IEquatable<TValue>, IComparable<TValue>
     {
         public override bool CanRead => true;
 

diff --git a/test/SmartEnum.JsonNet.UnitTests/SmartEnumNameConverterTests.cs b/test/SmartEnum.JsonNet.UnitTests/SmartEnumNameConverterTests.cs
@@ -20,6 +20,9 @@ public class TestClass
 
             [JsonConverter(typeof(SmartEnumNameConverter<TestEnumDouble, double>))]
             public TestEnumDouble Double { get; set; }
+
+            [JsonConverter(typeof(SmartEnumNameConverter<TestEnumString, string>))]
+            public TestEnumString String { get; set; }
         }
 
         static readonly TestClass TestInstance = new TestClass
@@ -28,14 +31,16 @@ public class TestClass
             Int16 = TestEnumInt16.Instance,
             Int32 = TestEnumInt32.Instance,
             Double = TestEnumDouble.Instance,
+            String = TestEnumString.Instance,
         };
 
         static readonly string JsonString =
 @"{
   ""Bool"": ""Instance"",
   ""Int16"": ""Instance"",
   ""Int32"": ""Instance"",
-  ""Double"": ""Instance""
+  ""Double"": ""Instance"",
+  ""String"": ""Instance""
 }";
 
         [Fact]
@@ -55,6 +60,7 @@ public void DeserializesNames()
             obj.Int16.Should().BeSameAs(TestEnumInt16.Instance);
             obj.Int32.Should().BeSameAs(TestEnumInt32.Instance);
             obj.Double.Should().BeSameAs(TestEnumDouble.Instance);
+            obj.String.Should().BeSameAs(TestEnumString.Instance);
         }
 
         [Fact]
@@ -68,6 +74,7 @@ public void DeserializesNullByDefault()
             obj.Int16.Should().BeNull();
             obj.Int32.Should().BeNull();
             obj.Double.Should().BeNull();
+            obj.String.Should().BeNull();
         }
 
         [Fact]