[DOC-587] Fix anchor links scrolling behaviour #251
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…in loadPage() and delete debug warnf page
|
Deploy Preview Available Via |
Simran-B
approved these changes
Sep 29, 2023
nerpaula
approved these changes
Sep 29, 2023
nerpaula
added a commit
that referenced
this pull request
Oct 5, 2023
* add permalinks to main hugo config * basic alias versioning working * add netlify redirect test * use _redirects into public for netlify redirect * try sudo chown on public * finalize netlify redirects * first draft of new alias handling * delete netlify redirects * cut _redirects from circleci * fix changeVersion * stable as redirect * alias header-links * fix title * add aliases to breadcrumbs and homepage button * add back to top button * add 404 call to not found page * use notfound page for real 404 * use notfound.html as real 404 page * fix 3.8 3.9 redirect issue * fix setVersionSelector * fix: fix not found version * fix: fix anchor links scroll behaviour, put the scroll function call in loadPage() and delete debug warnf page (#251) Co-authored-by: dandimeo <daniele@arangodb.com> * fix: fix introduced bug that didn't redirect to 3.8 3.9 old docs * [DOC-565] 404 page (#247) * first 404 implemenetaiton * fix: add missing / at homepage redirect * finish not found implementation * get rid of page-loading system in 404.html --------- Co-authored-by: dandimeo <daniele@arangodb.com> * fix search on page load --------- Co-authored-by: dandimeo <daniele@arangodb.com> Co-authored-by: Paula Mihu <97217318+nerpaula@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
modified the scrollToOpenApiFragment function to handle any fragment scrolling beahviour as scrollToFragment().
Include scrollToFragment() call in loadPage() so to handle the fragment scrolling in any kind of page loading
Upstream PRs