Skip to content

[DOC-573] Version aliases #232

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 32 commits into from
Oct 5, 2023
Merged

[DOC-573] Version aliases #232

merged 32 commits into from
Oct 5, 2023

Conversation

dandimeo
Copy link
Contributor

Description

Upstream PRs

  • 3.10:
  • 3.11:
  • 3.12:

@arangodb-docs-automation
Copy link
Contributor

Deploy Preview Available Via
https://deploy-preview-232--docs-hugo.netlify.app

@dandimeo dandimeo marked this pull request as draft September 22, 2023 09:21
@dandimeo dandimeo marked this pull request as ready for review September 22, 2023 11:29
Simran-B
Simran-B requested changes Sep 27, 2023
View reviewed changes
Copy link
Contributor

@Simran-B Simran-B left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks mostly good. One thing that doesn't work correctly is if you are on 3.11 and click the copy link to clipboard icon for an HTTP API option, the clipboard content starts with /stable instead of /3.11

@nerpaula nerpaula requested a review from Simran-B September 29, 2023 12:52
@Simran-B Simran-B mentioned this pull request Sep 29, 2023
Merged
dandimeo and others added 2 commits October 3, 2023 13:09
@dandimeo
[DOC-565] 404 page (#247)
3c3abb3 
* first 404 implemenetaiton

* fix: add missing / at homepage redirect

* finish not found implementation

* get rid of page-loading system in 404.html

---------

Co-authored-by: dandimeo <daniele@arangodb.com>
@nerpaula
Merge branch 'main' into DOC-573
f3a881b
@dandimeo
Copy link
Contributor Author

dandimeo commented Oct 3, 2023

Search version is not found at first page load.

@dandimeo
Copy link
Contributor Author

dandimeo commented Oct 4, 2023

Search fixed as of last commit

nerpaula
nerpaula approved these changes Oct 5, 2023
View reviewed changes
Copy link
Contributor

@nerpaula nerpaula left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nerpaula nerpaula merged commit 26dce2f into main Oct 5, 2023
@nerpaula nerpaula deleted the DOC-573 branch October 5, 2023 11:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nerpaula nerpaula nerpaula approved these changes

@Simran-B Simran-B Awaiting requested review from Simran-B

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dandimeo @Simran-B @nerpaula