Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Finance: fix test #314

Merged
merged 1 commit into from
May 16, 2018
Merged

Finance: fix test #314

merged 1 commit into from
May 16, 2018

Conversation

bingen
Copy link
Contributor

@bingen bingen commented May 16, 2018

With changes in PR #307 (commit bb6a18d) sending would revert instead
of failing with invalid opcode, so last test needed to change from
assertInvalidOpcode to assertRevert. We didn't realize because CI was
broken prior to PR #309.

Finance: fix test
87d6ac8 
With changes in PR #307 (commit bb6a18d) sending would revert instead
of failing with invalid opcode, so last test needed to change from
`assertInvalidOpcode` to `assertRevert`. We didn't realize because CI was
broken prior to PR #309.
@bingen bingen requested review from izqui and sohkai May 16, 2018 15:30
izqui
izqui approved these changes May 16, 2018
View reviewed changes
Copy link
Contributor

@izqui izqui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@bingen bingen merged commit c7044f6 into master May 16, 2018
@sohkai sohkai deleted the fix_finance_test branch May 16, 2018 17:57
ramilexe pushed a commit to ConsiderItDone/aragon-apps that referenced this pull request Dec 9, 2021
@bingen
Merge pull request aragon#314 from aragon/fix_finance_test
4e9139e 
Finance: fix test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@izqui izqui izqui approved these changes

@sohkai sohkai Awaiting requested review from sohkai

Assignees
No one assigned
Labels
app: finance audit: whg
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bingen @izqui