Fix CI #309
Merged
Fix CI #309
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sohkai
approved these changes
May 15, 2018
Fix issue with IForwarder interface, solidity-coverage was overriding `pure` clause.
sohkai
approved these changes
May 15, 2018
| @@ -40,7 +40,7 @@ | |||
| "babel-register": "^6.26.0", | |||
| "eth-gas-reporter": "^0.1.1", | |||
| "ganache-cli": "^6.1.0", | |||
| "solidity-coverage": "0.3.5", | |||
| "solidity-coverage": "0.4.3", | |||
There was a problem hiding this comment.
Oh wow, does this just work now? I remember having to do some funny things in order for this upgrade to work properly (sc-forks/solidity-coverage#182).
We also might as well specify 0.4.15 as the version: https://github.com/sc-forks/solidity-coverage/blob/master/CHANGELOG.md#0415--2018-03-28
Merged
MickdeGraaf
pushed a commit
to MickdeGraaf/aragon-apps
that referenced
this pull request
Jan 28, 2020
ramilexe
pushed a commit
to ConsiderItDone/aragon-apps
that referenced
this pull request
Dec 9, 2021
ramilexe
pushed a commit
to ConsiderItDone/aragon-apps
that referenced
this pull request
Dec 9, 2021
With changes in PR aragon#307 (commit 770eaea) sending would revert instead of failing with invalid opcode, so last test needed to change from `assertInvalidOpcode` to `assertRevert`. We didn't realize because CI was broken prior to PR aragon#309.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Failed tests were returning 0 (success) due to
ganache-cli.shuse.