Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add third party flag for os packages #4109

Closed
wants to merge 18 commits into from
Closed

feat: add third party flag for os packages #4109

wants to merge 18 commits into from

Conversation

DmitriyLewen
Copy link
Contributor

@DmitriyLewen DmitriyLewen commented Apr 24, 2023 •
edited
Loading

Description

There are cases when package has been installed from package manager (apk/dpkg/rpm), but that package is not vendor package.
Add third-party-os-pkgs flag to skip this package and parse files of this package as language packages.

TODO:

  • support of dpkg
  • support of apk
  • support of rpm
  • update docs

Related issues

Checklist

  • I've read the guidelines for contributing to this repository.
  • I've followed the conventions in the PR title.
  • I've added tests that prove my fix is effective or that my feature works.
  • I've updated the documentation with the relevant information (if needed).
  • I've added usage information (if the PR introduces new options)
  • I've included a "before" and "after" example to the description (if the PR is a user interface change).

@DmitriyLewen DmitriyLewen self-assigned this Apr 24, 2023
@DmitriyLewen DmitriyLewen marked this pull request as ready for review April 27, 2023 11:31
@DmitriyLewen DmitriyLewen mentioned this pull request Apr 28, 2023
Closed
@tuananh
Copy link

tuananh commented Apr 28, 2023

Thank you!

@DmitriyLewen DmitriyLewen marked this pull request as draft June 29, 2023 07:56
@DmitriyLewen DmitriyLewen marked this pull request as ready for review July 10, 2023 04:02
@github-actions
Copy link

This PR is stale because it has been labeled with inactivity.

@github-actions github-actions bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and will be auto-closed. label Sep 23, 2023
@DmitriyLewen DmitriyLewen removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and will be auto-closed. label Sep 29, 2023
@github-actions GitHub Actions
Copy link

This PR is stale because it has been labeled with inactivity.

@github-actions github-actions bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and will be auto-closed. label Nov 29, 2023
@github-actions github-actions bot closed this Dec 20, 2023
@DmitriyLewen DmitriyLewen reopened this Dec 20, 2023
@github-actions github-actions bot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and will be auto-closed. label Dec 21, 2023
@github-actions GitHub Actions
Copy link

This PR is stale because it has been labeled with inactivity.

@github-actions github-actions bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and will be auto-closed. label Feb 19, 2024
@github-actions github-actions bot closed this Mar 10, 2024
@DmitriyLewen DmitriyLewen removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and will be auto-closed. label Mar 11, 2024
@DmitriyLewen DmitriyLewen reopened this Mar 11, 2024
@github-actions GitHub Actions
Copy link

This PR is stale because it has been labeled with inactivity.

@github-actions github-actions bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and will be auto-closed. label May 11, 2024
@github-actions github-actions bot closed this Jun 1, 2024
@DmitriyLewen DmitriyLewen reopened this Jun 3, 2024
@github-actions github-actions bot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and will be auto-closed. label Jun 4, 2024
@codyharris-h2o-ai
Copy link

Do we have an ETA on when this might merge?

@knqyf263 knqyf263 mentioned this pull request Aug 1, 2024
Merged
6 tasks
@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 7, 2024

This PR is stale because it has been labeled with inactivity.

@github-actions github-actions bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and will be auto-closed. label Aug 7, 2024
@knqyf263
Copy link
Collaborator

knqyf263 commented Aug 7, 2024

Closing in favor of #7288

@knqyf263 knqyf263 closed this Aug 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AnaisUrlichs AnaisUrlichs AnaisUrlichs approved these changes

@knqyf263 knqyf263 Awaiting requested review from knqyf263 knqyf263 is a code owner

@itaysk itaysk Awaiting requested review from itaysk

Assignees

@DmitriyLewen DmitriyLewen

Labels
lifecycle/stale Denotes an issue or PR has remained open with no activity and will be auto-closed.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add flag to scan OS package files as language packages trivy did not detect java libs
5 participants
@DmitriyLewen @tuananh @codyharris-h2o-ai @knqyf263 @AnaisUrlichs