Skip to content

Conversation

@jandom
Copy link
Collaborator

@jandom jandom commented Dec 19, 2025

Summary

This PR provides changes to gradually harmonize some of the build process. Less moving pieces, and closer to best practices.

Changes

  • remove setup.py, this basically bypassed the messy deps in pyproject.toml but there are better ways to accomplish the same (pip install --no-deps .)
  • refactor requirements-test.txt into pyproject.toml, using pip "dependency group" to bake this into pyproject.toml and install only the test deps without the main deps
  • ignore .pre-commit-config.yaml because it's personal for now
  • add uv so that we can take advantage of of 'dep groups' in pyproject.toml
  • separate yaml and lock files for linux-64 and osx-arm64 (experimental, we shouldn't support Mac for now)

Related Issues

The 'main' deps declared in pyproject.toml will break the production environment. I've confirmed that setup.py route only worked because it skipped all the deps declared in pyproject.toml :)

Testing

Locally all dandy, launching a test job now.

Other Notes

@jandom jandom requested a review from jnwei December 19, 2025 14:26
@jandom jandom self-assigned this Dec 19, 2025
@jandom jandom added the safe-to-test Internal only label used to indicate PRs that are ready for automated CI testing. label Dec 19, 2025
@jandom jandom added safe-to-test Internal only label used to indicate PRs that are ready for automated CI testing. and removed safe-to-test Internal only label used to indicate PRs that are ready for automated CI testing. labels Dec 19, 2025
@jandom jandom added safe-to-test Internal only label used to indicate PRs that are ready for automated CI testing. and removed safe-to-test Internal only label used to indicate PRs that are ready for automated CI testing. labels Dec 19, 2025
@jandom jandom added safe-to-test Internal only label used to indicate PRs that are ready for automated CI testing. and removed safe-to-test Internal only label used to indicate PRs that are ready for automated CI testing. labels Dec 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

safe-to-test Internal only label used to indicate PRs that are ready for automated CI testing.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant