Skip to content

Conversation

@avelinoapheris
Copy link

  • Modify the base image to install the cuequivariance kernels. This also involve upgrading the base cuda version.
  • Add checks to ensure that the cuequivariance kernels are not loaded when using a setup without GPUs.

…ge + fixes avoid errors when cuequivariance is installed in setups without gpus
@jnwei
Copy link
Contributor

jnwei commented Nov 19, 2025

Hi @avelinoapheris thank you for the PR. Thank you for the fix regarding checking if cuEquivariance is installed.

Regarding updating the dockerfile - do you know if this new docker recipe would be compatible on GPUs that might have an older CUDA driver (<12.5) or are otherwise incompatible (e.g. NVIDIA/cuEquivariance#209)?

One option could be to support multiple docker recipes. We had a previous PR contribution for a dockerfile specifically for Blackwell GPUs

Copy link
Collaborator

@jandom jandom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great contribution @avelinoapheris – couple of questions/comments below

Many thanks!

# Install the package
WORKDIR /opt/openfold3
RUN python3 setup.py install
RUN pip install '.[cuequivariance]' --no-build-isolation && python setup.py install
Copy link
Collaborator

@jandom jandom Dec 12, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, I've also found that even with --no-build-isolation, you still need to run python setup.py install

Comment on lines +33 to +36
cueq_is_installed = (
importlib.util.find_spec("cuequivariance_torch") is not None
and torch.cuda.is_available()
)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we mutualize this into a helper function? it seems to be duplicated 2-3 times in this PR


# Runtime stage - use devel image for full CUDA support
FROM nvidia/cuda:12.1.1-cudnn8-devel-ubuntu22.04 AS runtime
FROM nvidia/cuda:12.6.1-cudnn-devel-ubuntu22.04 AS runtime
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This has me worried the most, we're adding multiple base build images support – is this strictly necessary for cuequivariance or just nice to have?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants