Skip to content

Conversation

@belyshevdenis
Copy link
Collaborator

No description provided.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes an assertion error in the DoubleLinkedListEntry destructor by addressing two key issues: ensuring proper cleanup during move assignment and correcting the namespace scope for the IsListEmpty function.

  • Adds a clear() call in the move assignment operator to properly clean up existing list elements
  • Changes IsListEmpty(this) to ::IsListEmpty(this) to use the global scope function instead of potentially ambiguous local scope

Reviewed Changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.

File Description
test/DoubleLinkedListTest.cpp Comprehensive test suite for DoubleLinkedList functionality including all list operations, iterators, and edge cases
test/CMakeLists.txt Adds the new test file to the build configuration
include/kf/DoubleLinkedListEntry.h Fixes namespace scope for IsListEmpty function call
include/kf/DoubleLinkedList.h Adds clear() call in move assignment operator to prevent destructor assertion

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
You can also share your feedback on Copilot code review for a chance to win a $100 gift card. Take the survey.

@SergiusTheBest SergiusTheBest merged commit 88693c6 into main Aug 14, 2025
2 checks passed
@SergiusTheBest SergiusTheBest deleted the KF-27-test-double-linked-list branch August 14, 2025 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants