Fix assert in ~DoubleLinkedListEntry (KF-27, #57)

belyshevdenis · web-flow · commit 88693c64094e · 2025-08-14T17:17:46.000+03:00
* add tests for DoubleLinkedList

* fix assert in list's node dtor
diff --git a/include/kf/DoubleLinkedList.h b/include/kf/DoubleLinkedList.h
@@ -36,6 +36,8 @@ namespace kf
         {
             if (this != &other)
             {
+                clear();
+
                 if (!other.isEmpty())
                 {
                     LIST_ENTRY* next = other.m_head.Flink;
diff --git a/test/DoubleLinkedListTest.cpp b/test/DoubleLinkedListTest.cpp
@@ -282,11 +282,12 @@ SCENARIO("DoubleLinkedListConstIterator")
 
 SCENARIO("DoubleLinkedListIterator")
 {
-    List list;
     TestNode node1{ 1 };
     TestNode node2{ 2 };
     TestNode node3{ 3 };
 
+    List list;
+
     WHEN("iterator is used to modify elements")
     {
         list.addLast(node1);

Original file line number	Diff line number	Diff line change
`@@ -36,6 +36,8 @@ namespace kf`
`36`	`36`	`{`
`37`	`37`	`if (this != &other)`
`38`	`38`	`{`
	`39`	`+ clear();`
	`40`	`+`
`39`	`41`	`if (!other.isEmpty())`
`40`	`42`	`{`
`41`	`43`	`LIST_ENTRY* next = other.m_head.Flink;`
Original file line number	Diff line number	Diff line change
`@@ -282,11 +282,12 @@ SCENARIO("DoubleLinkedListConstIterator")`
`282`	`282`
`283`	`283`	`SCENARIO("DoubleLinkedListIterator")`
`284`	`284`	`{`
`285`		`- List list;`
`286`	`285`	`TestNode node1{ 1 };`
`287`	`286`	`TestNode node2{ 2 };`
`288`	`287`	`TestNode node3{ 3 };`
`289`	`288`
	`289`	`+ List list;`
	`290`	`+`
`290`	`291`	`WHEN("iterator is used to modify elements")`
`291`	`292`	`{`
`292`	`293`	`list.addLast(node1);`