Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to version 2.14.0 #204

Merged
merged 3 commits into from
Sep 21, 2023
Merged

Update to version 2.14.0 #204

merged 3 commits into from
Sep 21, 2023

Conversation

DrDaveD
Copy link
Contributor

@DrDaveD DrDaveD commented Sep 18, 2023

This brings sif up to version 2.14.0 by pulling in PRs

The original PR descriptions was

add support for setting metadata on a descriptor

326 was actually after 2.14.0 but it just fixes a comment typo introduced in 324.

wobito and others added 3 commits September 18, 2023 17:16
Signed-off-by: Dave Dykstra <2129743+DrDaveD@users.noreply.github.com>
Co-authored-by: Adam Hughes <9903835+tri-adam@users.noreply.github.com>

Signed-off-by: Dave Dykstra <2129743+DrDaveD@users.noreply.github.com>
Signed-off-by: Dave Dykstra <2129743+DrDaveD@users.noreply.github.com>
@codecov
Copy link

codecov bot commented Sep 18, 2023

Codecov Report

Merging #204 (2f109ac) into main (09c706b) will decrease coverage by 0.25%.
The diff coverage is 46.42%.

@@            Coverage Diff             @@
##             main     #204      +/-   ##
==========================================
- Coverage   72.98%   72.73%   -0.25%     
==========================================
  Files          35       35              
  Lines        2950     2978      +28     
==========================================
+ Hits         2153     2166      +13     
- Misses        642      652      +10     
- Partials      155      160       +5     
Flag Coverage Δ
unittests 72.73% <46.42%> (-0.25%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
pkg/sif/create.go 71.08% <46.42%> (-1.79%) ⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@DrDaveD DrDaveD merged commit 5604443 into apptainer:main Sep 21, 2023
2 checks passed
@DrDaveD DrDaveD deleted the sylabs2.14.0 branch September 21, 2023 17:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants