Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add setMetadata #324

Merged
merged 2 commits into from
Sep 18, 2023
Merged

feat: add setMetadata #324

merged 2 commits into from
Sep 18, 2023

Conversation

wobito
Copy link
Contributor

@wobito wobito commented Sep 16, 2023

add support for setting metadata on a descriptor

@codecov
Copy link

codecov bot commented Sep 16, 2023

Codecov Report

Merging #324 (fcd29f3) into main (e9e4c73) will decrease coverage by 0.26%.
The diff coverage is 46.42%.

@@            Coverage Diff             @@
##             main     #324      +/-   ##
==========================================
- Coverage   73.03%   72.78%   -0.26%     
==========================================
  Files          35       35              
  Lines        2948     2976      +28     
==========================================
+ Hits         2153     2166      +13     
- Misses        640      650      +10     
- Partials      155      160       +5     
Files Changed Coverage Δ
pkg/sif/create.go 71.08% <46.42%> (-1.79%) ⬇️

@wobito wobito marked this pull request as ready for review September 16, 2023 13:38
Copy link
Member

@tri-adam tri-adam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great! Just need to fix up the documentation...

pkg/sif/create.go Outdated Show resolved Hide resolved
Co-authored-by: Adam Hughes <9903835+tri-adam@users.noreply.github.com>
@tri-adam tri-adam merged commit 3e01e9f into sylabs:main Sep 18, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants