Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: update scrollbar style #8661

Closed
wants to merge 4 commits into from
Closed

fix: update scrollbar style #8661

wants to merge 4 commits into from

Conversation

akash-codemonk
Copy link
Contributor

@akash-codemonk akash-codemonk commented Oct 20, 2021 •
edited by github-actions bot
Loading

Description

Update scrollbar styles everywhere to look the same across platforms.

  • Update comment list to make use of ScrollIndicator.
  • Add global css for scrollbar styles.
  • Property pane uses ScrollIndicator as well.
  • Update table widget header and body to show scroll on hover and hide when blurred to match the global scrollbar behaviour.

Related to #8576
Change scroll bar on Windows OS on datasources page

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

Manually on windows and mac

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

Test coverage results 🧪

🔴 Total coverage has decreased 
// Code coverage diff between base branch:release and head branch: fix/global-scrollbars
Status File % Stmts % Branch % Funcs % Lines
🔴 total 54.79 (0) 36.5 (-0.01) 33.42 (-0.01) 55.33 (0)
🔴 app/client/src/comments/AppComments/AppCommentThreads.tsx 57.14 (-3.33) 20.83 (-1.9) 33.33 (-6.67) 56.25 (-3.27)
🟢 app/client/src/pages/Editor/PropertyPane/index.tsx 83.62 (0.29) 69.3 (0) 70.37 (0) 85.32 (0.27)
🔴 app/client/src/selectors/commentsSelectors.ts 83.61 (-1.64) 61.76 (-2.95) 73.33 (0) 88.24 (-2.35)

@akash-codemonk akash-codemonk marked this pull request as draft October 20, 2021 13:42
@github-actions github-actions bot added the Bug Something isn't working label Oct 20, 2021
@github-actions
Copy link

Unable to find test scripts. Please add necessary tests to the PR.

@github-actions
Copy link

Unable to find test scripts. Please add necessary tests to the PR.

@akash-codemonk akash-codemonk marked this pull request as ready for review October 21, 2021 05:36
@ramsaptami
Copy link
Contributor

ramsaptami commented Oct 25, 2021 •
edited by loom-gif-previews bot
Loading

Hey @akash-codemonk, there's a boundary that appears on comment view that wasn't visible before because of the chunky scroll. Can we look at this?
LOOM DEMO
image

ramsaptami
ramsaptami previously approved these changes Oct 25, 2021
View reviewed changes
Copy link
Contributor

@ramsaptami ramsaptami left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested ok on deploy preview

@akash-codemonk
Copy link
Contributor Author

akash-codemonk commented Oct 26, 2021 •
edited
Loading

image

You mean the white boundary right?

@akash-codemonk
Copy link
Contributor Author

/ok-to-test sha=657885c

@mohanarpit mohanarpit deleted the fix/global-scrollbars branch October 8, 2022 02:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ramsaptami ramsaptami ramsaptami left review comments

@albinAppsmith albinAppsmith Awaiting requested review from albinAppsmith

Assignees
No one assigned
Labels
Bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@akash-codemonk @ramsaptami