fix:onTextChanged action gets triggered on typing numbers after 2 dec… #34355
Conversation
WalkthroughThe primary update to the Changes
Sequence Diagram(s)sequenceDiagram
participant User
participant CurrencyInputWidget
User->>CurrencyInputWidget: Types value
CurrencyInputWidget->>CurrencyInputWidget: Calls onValueChange(value)
CurrencyInputWidget->>CurrencyInputWidget: Validate fractional length
CurrencyInputWidget-->>User: Display validated value or error
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
Outside diff range and nitpick comments (1)
app/client/src/widgets/CurrencyInputWidget/widget/index.tsx (1)
Line range hint
411-411: Usingsuperin static methods is flagged as potentially confusing. Consider using the specific class name instead ofsuperto call superclass methods in static contexts to enhance clarity and maintainability.- super.getPropertyPaneContentConfig() + BaseInputWidget.getPropertyPaneContentConfig()Also applies to: 416-416, 427-427, 434-434
Tools
Biome
[error] 503-503: Change to an optional chain. (lint/complexity/useOptionalChain)
Unsafe fix: Change to an optional chain.
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (1)
- app/client/src/widgets/CurrencyInputWidget/widget/index.tsx (2 hunks)
Additional context used
Biome
app/client/src/widgets/CurrencyInputWidget/widget/index.tsx
[error] 411-411: Using super in a static context can be confusing. (lint/complexity/noThisInStatic)
super refers to a parent class.
Unsafe fix: Use the class name instead.
[error] 416-416: Using super in a static context can be confusing. (lint/complexity/noThisInStatic)
super refers to a parent class.
Unsafe fix: Use the class name instead.
[error] 427-427: Using super in a static context can be confusing. (lint/complexity/noThisInStatic)
super refers to a parent class.
Unsafe fix: Use the class name instead.
[error] 434-434: Using super in a static context can be confusing. (lint/complexity/noThisInStatic)
super refers to a parent class.
Unsafe fix: Use the class name instead.
[error] 503-503: Change to an optional chain. (lint/complexity/useOptionalChain)
Unsafe fix: Change to an optional chain.
Additional comments not posted (1)
app/client/src/widgets/CurrencyInputWidget/widget/index.tsx (1)
501-507: The changes introduced in theonValueChangemethod effectively prevent theonTextChangedaction from being triggered when the fractional part of the input exceeds the specified decimal places. This aligns with the PR's objective. However, consider using optional chaining when accessingthis.props.decimalsto ensure robustness in scenarios wherepropsmight be undefined.Verification successful
The
onValueChangemethod inapp/client/src/widgets/CurrencyInputWidget/widget/index.tsxuses the nullish coalescing operator (??) to handle cases wherethis.props.decimalsmight be undefined or null. This ensures that the method defaults to0in such scenarios, making the code robust.
const decimals = this.props.decimals ?? 0;This approach effectively handles undefined or null values for
this.props.decimals, ensuring the method operates correctly without additional optional chaining.Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify that the onValueChange method handles null and undefined values gracefully. # Test: Simulate a call to onValueChange with undefined decimals property. rg --type typescript $'onValueChange(undefined)'Length of output: 84
Script:
#!/bin/bash # Locate the implementation of the onValueChange method. ast-grep --lang typescript --pattern 'onValueChange($_) { $$$ }'Length of output: 514
Script:
#!/bin/bash # Locate the implementation of the onValueChange method with corrected pattern. ast-grep --lang typescript --pattern 'function onValueChange($$) { $$ }'Length of output: 74
Script:
#!/bin/bash # Locate the implementation of the onValueChange method using ripgrep. rg 'onValueChange' --type tsLength of output: 9579
Script:
#!/bin/bash # Extract the implementation of the onValueChange method in CurrencyInputWidget. rg 'onValueChange = ' app/client/src/widgets/CurrencyInputWidget/widget/index.tsx -A 20Length of output: 793
Tools
Biome
[error] 503-503: Change to an optional chain. (lint/complexity/useOptionalChain)
Unsafe fix: Change to an optional chain.
|
This PR has not seen activitiy for a while. It will be closed in 7 days unless further activity is detected. |
|
This PR has not seen activitiy for a while. It will be closed in 7 days unless further activity is detected. |
|
Hello @riodeuno |
|
Hello @KelvinOm @jsartisan , Could you please review this PR. |
Description:
Summary by CodeRabbit
CurrencyInputWidgetto correctly handle fractional part lengths, ensuring it respects the specified decimal places.PR Type
Bug fix
Description
onTextChangedaction from being triggered when typing numbers after the allowed decimal places in the Currency Input widget.