Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug]: onTextChanged action gets triggered on typing numbers after 2 decimal places #21363

Open
1 task done
shadabbuchh opened this issue Mar 13, 2023 · 0 comments
Open
1 task done

[Bug]: onTextChanged action gets triggered on typing numbers after 2 decimal places #21363

shadabbuchh opened this issue Mar 13, 2023 · 0 comments
Assignees
@somangshu @dilippitchika
Labels
Bug Something isn't working Currency Input Widget Issues related to currency input widget Low An issue that is neither critical nor breaks a user flow Needs Triaging Needs attention from maintainers to triage Production UX Improvement Widgets & Accelerators Pod Issues related to widgets & Accelerators Widgets Product This label groups issues related to widgets

Comments

@shadabbuchh
Copy link
Contributor

Is there an existing issue for this?

  • I have searched the existing issues

Description

In the Currency Input widget if we allow 2 decimal places and set a onTextChanged action, then on typing numbers after the 2nd decimal place the action gets triggered.

Steps To Reproduce

  1. D&D a Currency Input widget.
  2. Select 2 for Decimals allowed property.
  3. Not set some action for the onTextChanged property.
  4. Now place the cursor after the second decimal place in the widget.
  5. Press any number on the keyboard.

Expected: The onTextChanged property should not get triggered as only 2 decimal places are allowed.
Actual: The action is getting triggered.

Public Sample App

No response

Environment

Production

Issue video log

https://www.loom.com/share/380537946d364e4288a0036d269621d7

Version

Cloud
@shadabbuchh shadabbuchh added Bug Something isn't working UX Improvement Production Needs Triaging Needs attention from maintainers to triage Currency Input Widget Issues related to currency input widget Medium Issues that frustrate users due to poor UX labels Mar 13, 2023
@github-actions github-actions bot added the Widgets Product This label groups issues related to widgets label Mar 13, 2023
@dilippitchika dilippitchika added Low An issue that is neither critical nor breaks a user flow and removed Medium Issues that frustrate users due to poor UX labels Mar 13, 2023
prasad-madine added a commit to prasad-madine/appsmith that referenced this issue Jun 20, 2024
@prasad-madine
fix:onTextChanged action gets triggered on typing numbers after 2 dec…
0edfd84 
…imal places appsmithorg#21363
@prasad-madine prasad-madine mentioned this issue Jul 4, 2024
Open
@Nikhil-Nandagopal Nikhil-Nandagopal added the Widgets & Accelerators Pod Issues related to widgets & Accelerators label Aug 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@somangshu somangshu

@dilippitchika dilippitchika

Labels
Bug Something isn't working Currency Input Widget Issues related to currency input widget Low An issue that is neither critical nor breaks a user flow Needs Triaging Needs attention from maintainers to triage Production UX Improvement Widgets & Accelerators Pod Issues related to widgets & Accelerators Widgets Product This label groups issues related to widgets
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@Nikhil-Nandagopal @somangshu @dilippitchika @shadabbuchh