Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Stub /features call in tests #25104

Merged
merged 6 commits into from
Jul 5, 2023
Merged

chore: Stub /features call in tests #25104

merged 6 commits into from
Jul 5, 2023

Conversation

hetunandu
Copy link
Member

This change will stub the call to users/features to get the feature flags. By default it will return an empty list and rely on the client default flag list to enable/disable features

@github-actions github-actions bot added the skip-changelog Adding this label to a PR prevents it from being listed in the changelog label Jul 5, 2023
akash-codemonk
akash-codemonk previously approved these changes Jul 5, 2023
View reviewed changes
@hetunandu
Copy link
Member Author

/ok-to-test

@github-actions
Copy link

github-actions bot commented Jul 5, 2023

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/5461734761.
Workflow: Appsmith External Integration Test Workflow.
Commit: ``.
PR: 25104.
Perf tests will be available at https://app.appsmith.com/app/performance-infra-dashboard/pr-details-638dd7cd2913ba43778b915e?pr=25104&runId=5461734761_1

@Aishwarya-U-R Aishwarya-U-R requested a review from rahulbarwal July 5, 2023 08:39
Aishwarya-U-R
Aishwarya-U-R previously approved these changes Jul 5, 2023
View reviewed changes
Copy link
Contributor

@Aishwarya-U-R Aishwarya-U-R left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving Cypress changes!

@Aishwarya-U-R
Copy link
Contributor

@rahulbarwal - adding you as FYI - since you added the the fixtures that are removed now in this PR.

@github-actions

This comment was marked as outdated.

Sign in to view
@hetunandu
Copy link
Member Author

/build-deploy-preview skip-tests=true

@github-actions
Copy link

github-actions bot commented Jul 5, 2023

Deploying Your Preview: https://github.com/appsmithorg/appsmith/actions/runs/5463017180.
Workflow: On demand build Docker image and deploy preview.
skip-tests: true.
env: ``.
PR: 25104.
recreate: .

@hetunandu hetunandu dismissed stale reviews from Aishwarya-U-R and akash-codemonk via 7c61af0 July 5, 2023 10:14
@hetunandu
Copy link
Member Author

/ok-to-test

@github-actions
Copy link

github-actions bot commented Jul 5, 2023

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/5463089382.
Workflow: Appsmith External Integration Test Workflow.
Commit: ``.
PR: 25104.
Perf tests will be available at https://app.appsmith.com/app/performance-infra-dashboard/pr-details-638dd7cd2913ba43778b915e?pr=25104&runId=5463089382_1

@github-actions
Copy link

github-actions bot commented Jul 5, 2023

Deploy-Preview-URL: https://ce-25104.dp.appsmith.com

@github-actions

This comment was marked as outdated.

Sign in to view
@hetunandu hetunandu mentioned this pull request Jul 5, 2023
Merged
19 tasks
hetunandu added 2 commits July 5, 2023 16:08
@hetunandu
Reload with helper
b4b2e4b
@hetunandu
Merge branch 'release' into fix/cypress-featureflagging-stub
2049309 
# Conflicts:
#	app/server/appsmith-server/src/main/resources/features/init-flags.xml
@hetunandu
Copy link
Member Author

/ok-to-test

@github-actions
Copy link

github-actions bot commented Jul 5, 2023

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/5463922873.
Workflow: Appsmith External Integration Test Workflow.
Commit: ``.
PR: 25104.
Perf tests will be available at https://app.appsmith.com/app/performance-infra-dashboard/pr-details-638dd7cd2913ba43778b915e?pr=25104&runId=5463922873_1

@hetunandu
Revert "Reload with helper"
82e9f90 
This reverts commit b4b2e4b.
@hetunandu
Copy link
Member Author

/ok-to-test

@github-actions
Copy link

github-actions bot commented Jul 5, 2023

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/5464492423.
Workflow: Appsmith External Integration Test Workflow.
Commit: ``.
PR: 25104.
Perf tests will be available at https://app.appsmith.com/app/performance-infra-dashboard/pr-details-638dd7cd2913ba43778b915e?pr=25104&runId=5464492423_1

@github-actions
Copy link

github-actions bot commented Jul 5, 2023

Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/5464492423.
Commit: ``.
Cypress dashboard url: Click here!
All cypress tests have passed 🎉🎉🎉

@hetunandu hetunandu requested a review from Aishwarya-U-R July 5, 2023 13:59
@hetunandu hetunandu merged commit 87b6090 into release Jul 5, 2023
@hetunandu hetunandu deleted the fix/cypress-featureflagging-stub branch July 5, 2023 14:09
@hetunandu hetunandu mentioned this pull request Jul 11, 2023
Merged
hetunandu added a commit that referenced this pull request Jul 11, 2023
@hetunandu
fix: removes race conditions in recent perf optimisation (#25298)
6eb8a02 
We missed a race condition in: #25104 which caused some test cases to
fail. This would rarely happen to any new apps in production but to
ensure backwards compatibility we are updating the code itself
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Aishwarya-U-R Aishwarya-U-R Aishwarya-U-R approved these changes

@akash-codemonk akash-codemonk akash-codemonk left review comments

@rahulbarwal rahulbarwal Awaiting requested review from rahulbarwal

Assignees
No one assigned
Labels
skip-changelog Adding this label to a PR prevents it from being listed in the changelog skip-docs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hetunandu @Aishwarya-U-R @akash-codemonk