Skip to content

Commit

Permalink
updates
Browse files Browse the repository at this point in the history
  • Loading branch information
hetunandu committed Jul 5, 2023
1 parent 5b43123 commit 7c61af0
Show file tree
Hide file tree
Showing 4 changed files with 2 additions and 7 deletions.
1 change: 1 addition & 0 deletions CODEOWNERS
Original file line number Diff line number Diff line change
Expand Up @@ -38,6 +38,7 @@ app/client/src/ee/pages/Editor/NavigationSettings/LogoInput.tsx @dhruvikn
# New Developers Pod
app/client/src/ce/entities/FeatureFlag.ts @hetunandu
app/client/src/ee/entities/FeatureFlag.ts @hetunandu
app/server/appsmith-server/src/main/resources/features/init-flags.xml @hetunandu

# UI Builders Pod
app/client/generators/* @appsmithorg/ui-builders
Expand Down
2 changes: 1 addition & 1 deletion app/client/cypress/support/commands.js
Original file line number Diff line number Diff line change
Expand Up @@ -1127,7 +1127,7 @@ Cypress.Commands.add("startServerAndRoutes", () => {
}).as("postTenant");
cy.intercept("PUT", "/api/v1/git/discard/app/*").as("discardChanges");
cy.intercept("GET", "/api/v1/libraries/*").as("getLibraries");
featureFlagIntercept({});
featureFlagIntercept({}, false);
});

Cypress.Commands.add("startErrorRoutes", () => {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,6 @@ public enum FeatureFlagEnum {

// ------------------- These are actual feature flags meant to be used across the product ----------------------- //
release_datasource_environments_enabled,
MULTIPLE_PANES,
APP_NAVIGATION_LOGO_UPLOAD,
APP_EMBED_VIEW_HIDE_SHARE_SETTINGS_VISIBILITY,

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -10,11 +10,6 @@
value="me-eng1@appsmith.com,me-eng2@appsmith.com,me-qa1@appsmith.com,me-qa2@appsmith.com,me-demo@appsmith.com"/>
</flipstrategy>
</feature>
<feature uid="MULTIPLE_PANES" enable="true" description="Have multiple panes in the Appsmith IDE">
<flipstrategy class="com.appsmith.server.featureflags.strategies.EmailBasedRolloutStrategy">
<param name="emails" value="multipanes@appsmith.com,ndx@appsmith.com"/>
</flipstrategy>
</feature>
<feature uid="APP_NAVIGATION_LOGO_UPLOAD" enable="true"
description="Logo upload feature for app viewer navigation">
<flipstrategy class="com.appsmith.server.featureflags.strategies.EmailBasedRolloutStrategy">
Expand Down

0 comments on commit 7c61af0

Please sign in to comment.