Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug] Table continues to apply client side searching even when onSearchChange is configured #4039

Closed
Nikhil-Nandagopal opened this issue Apr 17, 2021 · 3 comments · Fixed by #4316
Closed

[Bug] Table continues to apply client side searching even when onSearchChange is configured #4039

Nikhil-Nandagopal opened this issue Apr 17, 2021 · 3 comments · Fixed by #4316
Assignees
@vicky-primathon
Labels
Bug Something isn't working Community Reported issues reported by community members High This issue blocks a user from building or impacts a lot of users Table Widget Verified When issue is retested post its fixed Widgets Product This label groups issues related to widgets

Comments

@Nikhil-Nandagopal
Copy link
Contributor

Steps to reproduce the behaviour:

  1. Drag a table
  2. Create a query and add a where clause to use similarity in PGSQL
  3. Display the query in the table
  4. Search for a query string like Jean Luc
  5. The query returns similar results like Jean Claude but the table filters these out on the client side
@Nikhil-Nandagopal Nikhil-Nandagopal added Bug Something isn't working Table Widget High This issue blocks a user from building or impacts a lot of users Community Reported issues reported by community members labels Apr 17, 2021
@github-actions github-actions bot added Widgets Product This label groups issues related to widgets UI Building Pod labels Apr 17, 2021
@areyabhishek
Copy link
Contributor

@Nikhil-Nandagopal What's the exact solution here? Could you describe it? We can ask @vicky-primathon to take a look at this.

@Nikhil-Nandagopal
Copy link
Contributor Author

@areyabhishek @riodeuno @vicky-primathon
The solution I was thinking of was to disable the client-side search if the user has configured a query onSearchTextChange.

@areyabhishek
Copy link
Contributor

And re-enable client side search if onSearchTextChange is reset. Sounds simple enough.

@somangshu somangshu removed their assignment Apr 26, 2021
@vicky-primathon vicky-primathon mentioned this issue May 5, 2021
Merged
7 tasks
@close-label close-label bot added the QA Needs QA attention label May 18, 2021
@prapullac prapullac added Verified When issue is retested post its fixed and removed QA Needs QA attention labels May 21, 2021
@somangshu somangshu mentioned this issue May 23, 2021
Closed
@somangshu somangshu mentioned this issue Jun 28, 2021
Closed
@somangshu somangshu mentioned this issue Oct 13, 2021
Closed
pedro-santos-rodrigues pushed a commit that referenced this issue Jun 20, 2024
@trishaanand
Merge pull request #4039 from appsmithorg/release
5cc2f75 
25/04 - Daily promotion
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@vicky-primathon vicky-primathon

Labels
Bug Something isn't working Community Reported issues reported by community members High This issue blocks a user from building or impacts a lot of users Table Widget Verified When issue is retested post its fixed Widgets Product This label groups issues related to widgets
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Disable client side search when server side search is enabled in table widget appsmithorg/appsmith
6 participants
@Nikhil-Nandagopal @somangshu @areyabhishek @vicky-primathon @prapullac @appsmith-bot