Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Search in filter of tables only works if I'm on the same page as the item being searched #4636

Closed
Rishabhkaul opened this issue May 23, 2021 · 7 comments
Assignees
Labels
Bug Something isn't working Table Widget Widgets Product This label groups issues related to widgets

Comments

@Rishabhkaul
Copy link
Contributor

Rishabhkaul commented May 23, 2021

While searching through a table, I am only able to filter for data on the page that I am on. So with pagination this becomes an issue.

Steps to reproduce the behaviour:

I've used the Applicant Tracker App to show case this issue, but this is a larger issue with Tables (since the same thing has happened on other apps as well).

https://www.loom.com/share/5bfea0ccb3514dfe9864fd59ed60383e

Important Details

  • Version: Cloud
  • OS: MacOSX Catalina
  • Browser: Chrome
@Rishabhkaul Rishabhkaul added Bug Something isn't working Needs Triaging Needs attention from maintainers to triage labels May 23, 2021
@Rishabhkaul Rishabhkaul changed the title [Bug] Search in tables only works if I'm on the same page as the item being searched [Bug] Search in filter of tables only works if I'm on the same page as the item being searched May 23, 2021
@areyabhishek areyabhishek added Table Widget and removed Needs Triaging Needs attention from maintainers to triage labels May 23, 2021
@github-actions github-actions bot added Widgets Product This label groups issues related to widgets UI Building Pod labels May 23, 2021
@areyabhishek
Copy link
Contributor

@somangshu does the table search work as intended? Is Rishabh supposed to connect the table search field property to a search query?

@somangshu
Copy link
Contributor

@areyabhishek we had this issue with the table widget when the client-side search would apply on the server-side search, This was resolved here and is in release right now.

Yes, the table widget search in case of the server-side pagination needs to be connected to a Query/API to get correct search results.
@Rishabhkaul could you provide more info on the reproducible steps.

@Rishabhkaul
Copy link
Contributor Author

Rishabhkaul commented May 23, 2021

@somangshu I just forked the template from the Appsmith site (https://www.appsmith.com/templates) and continued using it (with the mock DB). And then I went and searched in the table.

@somangshu
Copy link
Contributor

@Rishabhkaul @areyabhishek I have replicated this on the release environment and it seems to be working fine. However I can see some lag in the table widget in the Edit mode. Ill dig more into that. Let me know if you think the issue is resolved here.

If it is, then I would say we should update the template on the prod as the search query is not written properly and can lead to this or other errors.

@Nikhil-Nandagopal
Copy link
Contributor

seems to be working on prod. @Rishabhkaul can you share the link to the app where it's not working and invite us to it?

@somangshu
Copy link
Contributor

@Rishabhkaul After the release promotion yesterday this is working just fine. However the query written in the template is not correct and will result in wrong data population. Closing this.

@Rishabhkaul
Copy link
Contributor Author

Ok that makes sense, thanks @somangshu! cc @vihar maybe have a look at the query at some point since its in the template.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working Table Widget Widgets Product This label groups issues related to widgets
Projects
None yet
Development

No branches or pull requests

4 participants