Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug] Query Params do not encoded when the datasource url is a binding #3821

Closed
hetunandu opened this issue Apr 1, 2021 · 1 comment
Closed

[Bug] Query Params do not encoded when the datasource url is a binding #3821

hetunandu opened this issue Apr 1, 2021 · 1 comment
Labels
Backend This marks the issue or pull request to reference server code Bug Something isn't working Integrations Product Issues related to a specific integration Query & JS Pod Issues related to the query & JS Pod REST API plugin REST API plugin related issues

Comments

@hetunandu
Copy link
Member

Description

Where there is a datasource binding, the client cannot split the URL correctly and sets everything in the datasource URL field. We should extract and split this out in the server and encode the API request's correct parts before executing.

Steps to reproduce the behaviour:

  1. Create an API
  2. Add a binding in the datasource instead of a string like https://example.com.
  3. Add params to the same URL after ? that need encoding
  4. execute the request

Observation

The params are not encoded.
@hetunandu hetunandu added Bug Something isn't working Backend This marks the issue or pull request to reference server code API pane High This issue blocks a user from building or impacts a lot of users Core Query Execution Issues related to the execution of all queries labels Apr 1, 2021
@Nikhil-Nandagopal Nikhil-Nandagopal added Low An issue that is neither critical nor breaks a user flow and removed High This issue blocks a user from building or impacts a lot of users labels Aug 23, 2021
@Nikhil-Nandagopal Nikhil-Nandagopal removed this from the AP-RK Issues - Sep 21 milestone Aug 23, 2021
@Pranay105 Pranay105 added the Good First Issue Good for newcomers label Sep 22, 2021
@nidhi-nair nidhi-nair removed the Good First Issue Good for newcomers label Sep 28, 2021
@Nikhil-Nandagopal Nikhil-Nandagopal added High This issue blocks a user from building or impacts a lot of users and removed Low An issue that is neither critical nor breaks a user flow labels Nov 5, 2021
@Nikhil-Nandagopal Nikhil-Nandagopal added Good First Issue Good for newcomers Test and removed Good First Issue Good for newcomers Test labels Dec 23, 2021
@sumitsum sumitsum removed the High This issue blocks a user from building or impacts a lot of users label Feb 1, 2022
@Nikhil-Nandagopal Nikhil-Nandagopal added REST API plugin REST API plugin related issues and removed API pane labels Sep 12, 2022
@github-actions github-actions bot added the Integrations Product Issues related to a specific integration label Sep 12, 2022
@Nikhil-Nandagopal Nikhil-Nandagopal removed the Core Query Execution Issues related to the execution of all queries label Sep 13, 2022
@rohan-arthur
Copy link
Contributor

works now, see #11795

rajatagrawal pushed a commit that referenced this issue Apr 17, 2024
@hetunandu
chore: Add tests for IDE url utils (#3821)
cd52896 
## Description

Adds tests in EE sections for IDE url utils

Fixes #31870 

## Automation

/ok-to-test tags="@tag.IDE"

### 🔍 Cypress test results
<!-- This is an auto-generated comment: Cypress test results  -->
> [!IMPORTANT]
> Workflow run:
<https://github.com/appsmithorg/appsmith-ee/actions/runs/8449218737>
> Commit: `d7722c976d744e4f788db9282ea442e6c9448cdf`
> Cypress dashboard url: <a
href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=8449218737&attempt=1"
target="_blank">Click here!</a>
> All cypress tests have passed 🎉🎉🎉

<!-- end of auto-generated comment: Cypress test results  -->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Backend This marks the issue or pull request to reference server code Bug Something isn't working Integrations Product Issues related to a specific integration Query & JS Pod Issues related to the query & JS Pod REST API plugin REST API plugin related issues
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
10 participants
@ajinkyakulkarni @sumitsum @Nikhil-Nandagopal @nidhi-nair @trishaanand @hetunandu @areyabhishek @Pranay105 @appsmith-bot @rohan-arthur