Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]-[100]:Binding values directly in the API url does not get evaluated #11795

Closed
1 task done
danciaclara opened this issue Mar 11, 2022 · 4 comments · Fixed by #12022
Closed
1 task done

[Bug]-[100]:Binding values directly in the API url does not get evaluated #11795

danciaclara opened this issue Mar 11, 2022 · 4 comments · Fixed by #12022
Assignees
Labels
Backend This marks the issue or pull request to reference server code Bug Something isn't working High This issue blocks a user from building or impacts a lot of users Integrations Product Issues related to a specific integration Query & JS Pod Issues related to the query & JS Pod Reopen REST API plugin REST API plugin related issues Verified When issue is retested post its fixed

Comments

@danciaclara
Copy link
Contributor

danciaclara commented Mar 11, 2022

Is there an existing issue for this?

  • I have searched the existing issues

Description

If you bind widget values in the api URL, it evaluates to no value.
Screenshot 2022-03-11 at 12 22 59 PM
Screenshot 2022-03-11 at 12 24 22 PM

Steps To Reproduce

  1. Add an input widget with a random value (eg: baz)
  2. Create an API and in the URL bind the value of the input widget like this http://foo/bar?{{Input1.text}}
  3. We would expect the value to evaluate as http://foo/bar?baz, but it shows http://foo/bar

Public Sample App

Version

Cloud, Self-hosted - v1.6.14

@danciaclara danciaclara added Bug Something isn't working Needs Triaging Needs attention from maintainers to triage labels Mar 11, 2022
@danciaclara danciaclara added the Javascript Product Issues related to users writing javascript in appsmith label Mar 11, 2022
@hetunandu hetunandu removed their assignment Mar 11, 2022
@danciaclara danciaclara added Query & JS Pod Issues related to the query & JS Pod and removed Javascript Product Issues related to users writing javascript in appsmith labels Mar 11, 2022
@Nikhil-Nandagopal Nikhil-Nandagopal added High This issue blocks a user from building or impacts a lot of users Evaluated Value Issues related to evaluated values REST API plugin REST API plugin related issues labels Mar 11, 2022
@github-actions github-actions bot added the Javascript Product Issues related to users writing javascript in appsmith label Mar 11, 2022
@rashmi-rai rashmi-rai self-assigned this Mar 17, 2022
@close-label close-label bot added the QA Needs QA attention label Apr 1, 2022
@ramsaptami
Copy link
Contributor

Re-opening since the evaluated value from binding is still not recognized
image

@rashmi-rai
Copy link
Contributor

rashmi-rai commented Apr 20, 2022

For URLs like this: https://api.github.com?{{appsmith.user.name}} api is not returning correct dynamicBindingPathList . { key: "queryParameters[0].key" } would be missing.
However, URL https://api.github.com?{{appsmith.user.name}}= gives correct response.

Adding backend label

@rashmi-rai rashmi-rai added the Backend This marks the issue or pull request to reference server code label Apr 20, 2022
@rashmi-rai rashmi-rai removed their assignment Apr 20, 2022
@rohan-arthur
Copy link
Contributor

rohan-arthur commented May 2, 2022

Event: BINDING_SUCCESS,
Properties:
propertyPath = config.path
entityType = API
unevalValue contains ?{{
...6m usage: 25

Stats

Stat Values
Reach      25
Effort (months)  0.5

@Nikhil-Nandagopal Nikhil-Nandagopal changed the title [Bug]: Binding values directly in the API url does not get evaluated [Bug]-[Infinity]:Binding values directly in the API url does not get evaluated May 2, 2022
@rohan-arthur rohan-arthur added the needs estimate according to https://bit.ly/3JNaYTh label May 2, 2022
@Nikhil-Nandagopal Nikhil-Nandagopal changed the title [Bug]-[Infinity]:Binding values directly in the API url does not get evaluated [Bug]-[100]:Binding values directly in the API url does not get evaluated May 11, 2022
@ajinkyakulkarni ajinkyakulkarni removed the needs estimate according to https://bit.ly/3JNaYTh label May 11, 2022
@nidhi-nair nidhi-nair removed the Needs Triaging Needs attention from maintainers to triage label Jul 29, 2022
@Nikhil-Nandagopal Nikhil-Nandagopal added the Integrations Product Issues related to a specific integration label Sep 12, 2022
@bharath31
Copy link

bharath31 commented Feb 3, 2023

I don't think this is a problem with evaluations. Looks like the URL pattern is incorrect.

I also don't see any validations being run on the API URL. For instance, typing h:/acme.com on the API URL bar doesn't throw any error. cc: @sribalajig @rohan-arthur

@bharath31 bharath31 closed this as not planned Won't fix, can't repro, duplicate, stale Feb 3, 2023
@bharath31 bharath31 removed the Evaluated Value Issues related to evaluated values label Feb 7, 2023
@bharath31 bharath31 reopened this Feb 7, 2023
@github-actions github-actions bot removed the Javascript Product Issues related to users writing javascript in appsmith label Feb 7, 2023
@ramsaptami ramsaptami added the Verified When issue is retested post its fixed label Apr 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Backend This marks the issue or pull request to reference server code Bug Something isn't working High This issue blocks a user from building or impacts a lot of users Integrations Product Issues related to a specific integration Query & JS Pod Issues related to the query & JS Pod Reopen REST API plugin REST API plugin related issues Verified When issue is retested post its fixed
Projects
None yet
Development

Successfully merging a pull request may close this issue.